Bug 33137 - Make sure columns on transactions and 'pay fines' tab are matching up
Summary: Make sure columns on transactions and 'pay fines' tab are matching up
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low trivial (vote)
Assignee: Lucas Gass
QA Contact: Martin Renvoize
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-04 15:30 UTC by Katrin Fischer
Modified: 2023-12-28 20:47 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.05,22.05.12, 21.11.20


Attachments
Bug 33137: Add Home library to pay-fines-table and table settings (2.34 KB, patch)
2023-03-08 16:28 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 33137: Add call number to pay-fines-table and table settings (2.00 KB, patch)
2023-03-08 16:41 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 33137: Add Home library to pay-fines-table and table settings (2.41 KB, patch)
2023-03-09 10:39 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 33137: Add call number to pay-fines-table and table settings (2.07 KB, patch)
2023-03-09 10:39 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 33137: Make column names match (718 bytes, patch)
2023-03-09 13:17 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 33137: Add Home library to pay-fines-table and table settings (2.41 KB, patch)
2023-03-09 14:03 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 33137: Add call number to pay-fines-table and table settings (2.07 KB, patch)
2023-03-09 14:03 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 33137: Make column names match (784 bytes, patch)
2023-03-09 14:03 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 33137: Add Home library to pay-fines-table and table settings (2.47 KB, patch)
2023-03-15 17:58 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 33137: Add call number to pay-fines-table and table settings (2.13 KB, patch)
2023-03-15 17:58 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 33137: Make column names match (849 bytes, patch)
2023-03-15 17:58 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2023-03-04 15:30:02 UTC
The information visible on the transactions and 'pay fines' tabs is drifting apart with different columns visible on each. 

It would be nice to make them consistent again.
Comment 1 Katrin Fischer 2023-03-04 15:31:06 UTC
* home library 
* call number (bug 32977)
Comment 2 Lucas Gass 2023-03-08 16:28:19 UTC
Created attachment 147967 [details] [review]
Bug 33137: Add Home library to  pay-fines-table and table settings

To test:
1. Apply patch and restart_All
2. From a patron's Accounting tab add some invoices that are related to an item.
3. From the 'Make a payemnt' notice the new Home library column. Make sure it displays correctly and is the same as what you see on the 'Transactions' tab.
4. Using Table settings, make sure you can properly hide the column.
Comment 3 Lucas Gass 2023-03-08 16:41:55 UTC
Created attachment 147968 [details] [review]
Bug 33137: Add call number to pay-fines-table and table settings

To test:
1. Apply patch and restart_all
2. From a patron's Accounting tab add some invoices that are related to an item.
3. From the 'Make a payemnt' notice the new Call number column.
4. Using Table settings, make sure you can properly hide the column.
Comment 4 ByWater Sandboxes 2023-03-09 10:39:15 UTC
Created attachment 147990 [details] [review]
Bug 33137: Add Home library to pay-fines-table and table settings

To test:
1. Apply patch and restart_All
2. From a patron's Accounting tab add some invoices that are related to an item.
3. From the 'Make a payemnt' notice the new Home library column. Make sure it displays correctly and is the same as what you see on the 'Transactions' tab.
4. Using Table settings, make sure you can properly hide the column.

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Comment 5 ByWater Sandboxes 2023-03-09 10:39:17 UTC
Created attachment 147991 [details] [review]
Bug 33137: Add call number to pay-fines-table and table settings

To test:
1. Apply patch and restart_all
2. From a patron's Accounting tab add some invoices that are related to an item.
3. From the 'Make a payemnt' notice the new Call number column.
4. Using Table settings, make sure you can properly hide the column.

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Comment 6 Sally 2023-03-09 10:41:17 UTC
Note:  to test, make sure you apply bug 32977 first.

The only thing I noticed is that in table settings, the column names differ.

In Patron > account-fines, the column name is:  home_library

With this patch, in Patron > pay, the column name is:  homebranch

Should the two column names match?

Otherwise, this works as described, so signing off - thanks for the patch.
Comment 7 Lucas Gass 2023-03-09 13:17:57 UTC
Created attachment 148000 [details] [review]
Bug 33137: Make column names match
Comment 8 Lucas Gass 2023-03-09 13:18:46 UTC
(In reply to Sally from comment #6)
> Note:  to test, make sure you apply bug 32977 first.
> 
> The only thing I noticed is that in table settings, the column names differ.
> 
> In Patron > account-fines, the column name is:  home_library
> 
> With this patch, in Patron > pay, the column name is:  homebranch
> 
> Should the two column names match?
> 
> Otherwise, this works as described, so signing off - thanks for the patch.

I added a follow-up to make the column names match as 'home_library'. 

Thanks Sally!
Comment 9 ByWater Sandboxes 2023-03-09 14:03:14 UTC
Created attachment 148001 [details] [review]
Bug 33137: Add Home library to pay-fines-table and table settings

To test:
1. Apply patch and restart_All
2. From a patron's Accounting tab add some invoices that are related to an item.
3. From the 'Make a payemnt' notice the new Home library column. Make sure it displays correctly and is the same as what you see on the 'Transactions' tab.
4. Using Table settings, make sure you can properly hide the column.

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Comment 10 ByWater Sandboxes 2023-03-09 14:03:16 UTC
Created attachment 148002 [details] [review]
Bug 33137: Add call number to pay-fines-table and table settings

To test:
1. Apply patch and restart_all
2. From a patron's Accounting tab add some invoices that are related to an item.
3. From the 'Make a payemnt' notice the new Call number column.
4. Using Table settings, make sure you can properly hide the column.

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Comment 11 ByWater Sandboxes 2023-03-09 14:03:17 UTC
Created attachment 148003 [details] [review]
Bug 33137: Make column names match

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Comment 12 Sally 2023-03-09 14:04:08 UTC
(In reply to Lucas Gass from comment #8)
> I added a follow-up to make the column names match as 'home_library'. 
> 
> Thanks Sally!

Awesome, thanks Lucas!  

I retested with the follow up and all is working well.
Comment 13 Martin Renvoize 2023-03-15 17:58:20 UTC
Created attachment 148236 [details] [review]
Bug 33137: Add Home library to pay-fines-table and table settings

To test:
1. Apply patch and restart_All
2. From a patron's Accounting tab add some invoices that are related to an item.
3. From the 'Make a payemnt' notice the new Home library column. Make sure it displays correctly and is the same as what you see on the 'Transactions' tab.
4. Using Table settings, make sure you can properly hide the column.

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 14 Martin Renvoize 2023-03-15 17:58:22 UTC
Created attachment 148237 [details] [review]
Bug 33137: Add call number to pay-fines-table and table settings

To test:
1. Apply patch and restart_all
2. From a patron's Accounting tab add some invoices that are related to an item.
3. From the 'Make a payemnt' notice the new Call number column.
4. Using Table settings, make sure you can properly hide the column.

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 15 Martin Renvoize 2023-03-15 17:58:25 UTC
Created attachment 148238 [details] [review]
Bug 33137: Make column names match

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 16 Martin Renvoize 2023-03-15 17:58:45 UTC
Great work everyone, Passing QA
Comment 17 Tomás Cohen Arazi 2023-03-27 09:43:47 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 18 Matt Blenkinsop 2023-04-11 08:54:40 UTC
Nice work everyone!

Pushed to stable for 22.11.x
Comment 19 Lucas Gass 2023-04-24 16:57:55 UTC
Backported to 22.05.x for upcoming 22.05.12
Comment 20 Arthur Suzuki 2023-05-03 18:36:57 UTC
applied to 21.11.x for 21.11.20
Comment 21 Jonathan Druart 2023-09-22 13:55:43 UTC
There are 2 columns missing in the footer: https://snipboard.io/vyBt2F.jpg