Bug 33185 - Use template wrapper for tabs on authority and biblio MARC details
Summary: Use template wrapper for tabs on authority and biblio MARC details
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 32571
Blocks: 34334
  Show dependency treegraph
 
Reported: 2023-03-09 17:43 UTC by Owen Leonard
Modified: 2023-12-28 20:46 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.05


Attachments
Bug 33185: Use template wrapper for tabs on authority and biblio MARC details (11.82 KB, patch)
2023-03-09 17:52 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33185: Use template wrapper for tabs on authority and biblio MARC details (11.90 KB, patch)
2023-03-13 15:39 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 33185: Use template wrapper for tabs on authority and biblio MARC details (11.94 KB, patch)
2023-04-08 21:58 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-03-09 17:43:31 UTC
Continuing the work of Bug 32571, the bibliographic MARC detail page and authority detail pages should be updated to use the new WRAPPER for tabs.
Comment 1 Owen Leonard 2023-03-09 17:52:31 UTC
Created attachment 148023 [details] [review]
Bug 33185: Use template wrapper for tabs on authority and biblio MARC details

This patch updates the MARC detail views of bibliographic and authority
records so that they use the new WRAPPER directives to build tabs.

To test, apply the patch and locate a bibliographic record in the
catalog.

- Click the "MARC" menu item in the left-hand sidebar.
- Confirm that all tabs work correctly.

Perform the same test by going to Authorities and doing a search for
authorities. Clicking one of the results should take you to a
tabbed MARC view.
Comment 2 Matt Blenkinsop 2023-03-13 15:39:43 UTC
Created attachment 148128 [details] [review]
Bug 33185: Use template wrapper for tabs on authority and biblio MARC details

This patch updates the MARC detail views of bibliographic and authority
records so that they use the new WRAPPER directives to build tabs.

To test, apply the patch and locate a bibliographic record in the
catalog.

- Click the "MARC" menu item in the left-hand sidebar.
- Confirm that all tabs work correctly.

Perform the same test by going to Authorities and doing a search for
authorities. Clicking one of the results should take you to a
tabbed MARC view.

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Comment 3 Katrin Fischer 2023-04-08 21:58:07 UTC
Created attachment 149323 [details] [review]
Bug 33185: Use template wrapper for tabs on authority and biblio MARC details

This patch updates the MARC detail views of bibliographic and authority
records so that they use the new WRAPPER directives to build tabs.

To test, apply the patch and locate a bibliographic record in the
catalog.

- Click the "MARC" menu item in the left-hand sidebar.
- Confirm that all tabs work correctly.

Perform the same test by going to Authorities and doing a search for
authorities. Clicking one of the results should take you to a
tabbed MARC view.

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi 2023-04-13 14:49:27 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 5 Jacob O'Mara 2023-04-16 20:37:44 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.