The comments I added to html_helpers.inc for documenting usage of the tab and breadcrumbs wrappers are showing up in translations. #: koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc:357 #, c-format msgid "" "%s [%%# BOOTSTRAP TAB WRAPPER USAGE [ WRAPPER tabs id= \"tabs_container_id" "\" ] [ WRAPPER tabs_nav ] [ WRAPPER tab_item tabname= \"tab_name_1\" " The translation tool seems to have a problem with a multi-line Template::Toolkit comment. The workaround is to comment each line individually.
Created attachment 148662 [details] [review] Bug 33332: Fix formatting of TT comments to improve translations This patch reformats some Template::Toolkit multi-line comments in html_helpers.inc so that each line is commented separately. This seems to prevent the translation tool from putting the comments into the po file. To test, apply the patch and confirm that pages which use the breadcrumbs and tabs WRAPPER directives still work correctly: - Breadcrumbs: staff client home page, about page, error page. - Tabs: Administration -> Library transfer limits or circulation alerts. - To test translatability, run the translation tool for any language, e.g. perl misc/translator/translate update fr-FR Search the regenerated po file (in this example misc/translator/po/fr-FR-staff-prog.po) to confirm that there is no instance of something like "[%%# BOOTSTRAP BREADCRUMBS WRAPPER USAGE"
Created attachment 149285 [details] [review] Bug 33332: Fix formatting of TT comments to improve translations This patch reformats some Template::Toolkit multi-line comments in html_helpers.inc so that each line is commented separately. This seems to prevent the translation tool from putting the comments into the po file. To test, apply the patch and confirm that pages which use the breadcrumbs and tabs WRAPPER directives still work correctly: - Breadcrumbs: staff client home page, about page, error page. - Tabs: Administration -> Library transfer limits or circulation alerts. - To test translatability, run the translation tool for any language, e.g. perl misc/translator/translate update fr-FR Search the regenerated po file (in this example misc/translator/po/fr-FR-staff-prog.po) to confirm that there is no instance of something like "[%%# BOOTSTRAP BREADCRUMBS WRAPPER USAGE" Signed-off-by: David Nind <david@davidnind.com>
I think I tested this correctly, but it may need another sign off from someone more familiar with the translation process.
Created attachment 149315 [details] [review] Bug 33332: Fix formatting of TT comments to improve translations This patch reformats some Template::Toolkit multi-line comments in html_helpers.inc so that each line is commented separately. This seems to prevent the translation tool from putting the comments into the po file. To test, apply the patch and confirm that pages which use the breadcrumbs and tabs WRAPPER directives still work correctly: - Breadcrumbs: staff client home page, about page, error page. - Tabs: Administration -> Library transfer limits or circulation alerts. - To test translatability, run the translation tool for any language, e.g. perl misc/translator/translate update fr-FR Search the regenerated po file (in this example misc/translator/po/fr-FR-staff-prog.po) to confirm that there is no instance of something like "[%%# BOOTSTRAP BREADCRUMBS WRAPPER USAGE" Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work everyone! Pushed to stable for 22.11.x
Missing dependencies for 22.05.x, no backport.
*** Bug 30729 has been marked as a duplicate of this bug. ***