Bug 33383 - Use template wrapper for breadcrumbs: Course reserves
Summary: Use template wrapper for breadcrumbs: Course reserves
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 32507
Blocks:
  Show dependency treegraph
 
Reported: 2023-03-31 14:26 UTC by Owen Leonard
Modified: 2023-12-28 20:44 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.05


Attachments
Bug 33383: Use template wrapper for breadcrumbs: Course reserves (13.74 KB, patch)
2023-03-31 14:43 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33383: Use template wrapper for breadcrumbs: Course reserves (13.80 KB, patch)
2023-03-31 15:55 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 33383: Use template wrapper for breadcrumbs: Course reserves (13.85 KB, patch)
2023-04-08 20:58 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-03-31 14:26:51 UTC
To continue the process started by Bug 32507, this patch will update course reserves templates so that they use the new template wrapper for breadcrumbs.

- course_reserves/add_items-step1.tt
- course_reserves/add_items-step2.tt
- course_reserves/batch_add_items.tt
- course_reserves/batch_rm_items.tt
- course_reserves/course-details.tt
- course_reserves/course-reserves.tt
- course_reserves/course.tt
- course_reserves/invalid-course.tt
Comment 1 Owen Leonard 2023-03-31 14:43:12 UTC
Created attachment 149039 [details] [review]
Bug 33383: Use template wrapper for breadcrumbs: Course reserves

This patch updates several course reserves templates so that they use
the new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Course reserves
  - New course
  - Edit course
  - Batch remove reserves
  - Course details
    - Add reserves (step one and two)
    - Batch add reserves
Comment 2 ByWater Sandboxes 2023-03-31 15:55:34 UTC
Created attachment 149045 [details] [review]
Bug 33383: Use template wrapper for breadcrumbs: Course reserves

This patch updates several course reserves templates so that they use
the new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Course reserves
  - New course
  - Edit course
  - Batch remove reserves
  - Course details
    - Add reserves (step one and two)
    - Batch add reserves

Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Comment 3 Katrin Fischer 2023-04-08 20:58:38 UTC
Created attachment 149310 [details] [review]
Bug 33383: Use template wrapper for breadcrumbs: Course reserves

This patch updates several course reserves templates so that they use
the new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Course reserves
  - New course
  - Edit course
  - Batch remove reserves
  - Course details
    - Add reserves (step one and two)
    - Batch add reserves

Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi 2023-04-12 12:27:56 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 5 Jacob O'Mara 2023-04-16 20:38:20 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.