When recording a cashup the confirmation button in the modal should be 'yellow' for the primary action. * Enable cash registers and create a cash register * Go to Tools > Transaction history for ... * Click on 'Record cashup'
Created attachment 169617 [details] [review] Bug 33453: Change the button class of the record cashup modal to btn-primary To test: 1. Go to System Preferences > find and enable "Use cash registers" 2. Go to Administration > "Cash registers" and create a new cash register 3. Go to Tools > "Transaction history for" > "Record cashup" 4. Click "Record cashup" 5. Modal with change: "Confirm" should be yellow and primary.
Created attachment 169621 [details] [review] Bug 33453: Change the button class of the record cashup modal to btn-primary To test: 1. Go to System Preferences > find and enable "Use cash registers" 2. Go to Administration > "Cash registers" and create a new cash register 3. Go to Tools > "Transaction history for" > "Record cashup" 4. Click "Record cashup" 5. Modal with change: "Confirm" should be yellow and primary.
Created attachment 169641 [details] [review] Bug 33453: Change the button class of the record cashup modal to btn-primary To test: 1. Go to System Preferences > find and enable "Use cash registers" 2. Go to Administration > "Cash registers" and create a new cash register 3. Go to Tools > "Transaction history for" > "Record cashup" 4. Click "Record cashup" 5. Modal with change: "Confirm" should be yellow and primary. Signed-off-by: David Nind <david@davidnind.com>
Hi. I have added a release note. I also changed the bug from an enhancement to a minor bug, as it is something inconsistent with the rest of the UI that requires fixing. Everything works as expected - nice work! To get credit on the dashboard (https://dashboard.koha-community.org/), and to be listed as a Koha developer on the Koha timeline page, please update the assignee for the bug. David Nind
Whilst the code here is good, I'd really like to see accountability in the author of the patch.. we shouldn't be sharing accounts for authoring commits.. Please correct the patch by adding a proper author to it.
Hi Martin This was for a 2 hour bug squashing session. I'll contact the author to change the Assignee on the bug report. It's not a regular occurrence that we're sharing authorship. If the code is fine can we please set this back to Signed Off?
Sorry Martin! Aleisha did remind me to do this, and then I forgot :) Was a pleasure to participate in some Koha development for the first time.
(In reply to Vicki from comment #7) > Sorry Martin! > > Aleisha did remind me to do this, and then I forgot :) > > Was a pleasure to participate in some Koha development for the first time. Hi Vicky, if you let me know which name you want to appear and if this email address is ok to use, I can update the patch file for you with that information to move it back into the queue. Thanks for participating and providing a patch!
Created attachment 169940 [details] [review] Bug 33453: Change the button class of the record cashup modal to btn-primary To test: 1. Go to System Preferences > find and enable "Use cash registers" 2. Go to Administration > "Cash registers" and create a new cash register 3. Go to Tools > "Transaction history for" > "Record cashup" 4. Click "Record cashup" 5. Modal with change: "Confirm" should be yellow and primary. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Thanks Vicki (and Aliesha for organising the bug squashing event), I've amended the patch and passed it now, many thanks Martin
Pushed for 24.11! Well done everyone, thank you!
Congratulations Vicki, you are now officially a Koha developer :)
Backported to 24.05.x for upcoming 24.05.04
Pushed to 23.11.x for 23.11.09
Not backporting to 23.05.x unless requested