Bug 33455 - Heading on 'update password' page is too big
Summary: Heading on 'update password' page is too big
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Sam Lewis
QA Contact: Matt Blenkinsop
URL:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2023-04-08 20:36 UTC by Katrin Fischer
Modified: 2024-09-18 04:04 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the heading for the patron change password page in the staff interface (Patrons > search for a patron > Change password). It was previously part of the form area with the white background, when it should have been above it like other page headings.
Version(s) released in:
24.11.00,24.05.04,23.11.09
Circulation function:

Attachments
Bug 33455: The h1 heading on the change passwordpage is too big and should be outside of the legend. (1.53 KB, patch)
2024-07-25 23:30 UTC, Koha Training Catalyst 		Details | Diff | Splinter Review
Bug 33455: Fix the size of the patron change password heading (1.74 KB, patch)
2024-07-26 00:14 UTC, David Nind 		Details | Diff | Splinter Review
Bug 33455: Fix the size of the patron change password heading (1.82 KB, patch)
2024-07-26 11:00 UTC, Matt Blenkinsop 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2023-04-08 20:36:20 UTC 
The h1 heading on the change password page is too big and should be outside of the legend.
Comment 1 Koha Training Catalyst 2024-07-25 23:30:40 UTC Comment hidden (obsolete)
Comment 2 David Nind 2024-07-26 00:14:16 UTC Comment hidden (obsolete)
Comment 3 David Nind 2024-07-26 00:22:45 UTC 
Hi.

I have updated the commit message and added a release note.

I also changed the bug from an enhancement to a normal bug, as it is something inconsistent with the rest of the UI that requires fixing.

Everything works as expected - nice work!

To get credit on the dashboard (https://dashboard.koha-community.org/), and to be listed as a Koha developer on the Koha timeline page, please update the assignee for the bug.

David Nind
Comment 4 Matt Blenkinsop 2024-07-26 11:00:02 UTC 
Created attachment 169689 [details] [review]
Bug 33455: Fix the size of the patron change password heading

The H1 heading on the patron change password page in the staff
interface is too big and should be outside of the area with
form area with the white background.

Test plan:
1. In the staff interface, click on top right of menu and navigate
   to my account.
2. Click the 'Change password' button.
3. Note that title is now outside the legend and font size is
   comparable to other H1 headings (e.g. Duplicate).

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Comment 5 Martin Renvoize (ashimema) 2024-07-26 12:55:44 UTC 
Thanks for all the hard work!

Pushed to main for the next 24.11.00 release as RM Assistant
Comment 6 Lucas Gass (lukeg) 2024-08-29 15:00:47 UTC 
Backported to 24.05.x for upcoming 24.05.04
Comment 7 Fridolin Somers 2024-09-10 14:47:44 UTC 
Pushed to 23.11.x for 23.11.09
Comment 8 Wainui Witika-Park 2024-09-18 04:04:37 UTC 
Not backporting to 23.05.x unless requested