Bug 33869 - Move Matcher.t to db_dependent
Summary: Move Matcher.t to db_dependent
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Marcel de Rooy
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 34336
  Show dependency tree / graph
 
Reported: 2023-05-31 13:07 UTC by Marcel de Rooy
Modified: 2023-12-28 20:47 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00
Circulation function:

Attachments
Bug 33869: Matcher.t - use TestBuilder (3.09 KB, patch)
2023-05-31 13:10 UTC, Marcel de Rooy 		Details | Diff | Splinter Review
Bug 33869: Matcher.t - indentation and whitespace changes (3.33 KB, patch)
2023-05-31 13:10 UTC, Marcel de Rooy 		Details | Diff | Splinter Review
Bug 33869: Move Matcher.t to t/db_dependent (636 bytes, patch)
2023-05-31 13:10 UTC, Marcel de Rooy 		Details | Diff | Splinter Review
Bug 33869: Matcher.t - use TestBuilder (3.13 KB, patch)
2023-07-14 08:24 UTC, Matt Blenkinsop 		Details | Diff | Splinter Review
Bug 33869: Matcher.t - indentation and whitespace changes (3.38 KB, patch)
2023-07-14 08:24 UTC, Matt Blenkinsop 		Details | Diff | Splinter Review
Bug 33869: Move Matcher.t to t/db_dependent (679 bytes, patch)
2023-07-14 08:24 UTC, Matt Blenkinsop 		Details | Diff | Splinter Review
Bug 33869: Matcher.t - use TestBuilder (3.19 KB, patch)
2023-09-01 12:01 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 33869: Matcher.t - indentation and whitespace changes (3.43 KB, patch)
2023-09-01 12:02 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 33869: Move Matcher.t to t/db_dependent (735 bytes, patch)
2023-09-01 12:02 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2023-05-31 13:07:57 UTC 
Not much work to replace T::D::C here by a few TestBuilder records in marc_matchers table.
Comment 1 Marcel de Rooy 2023-05-31 13:10:09 UTC 
Created attachment 151872 [details] [review]
Bug 33869: Matcher.t - use TestBuilder

Remove T::D::C

Test plan:
Run t/Matcher.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 2 Marcel de Rooy 2023-05-31 13:10:11 UTC 
Created attachment 151873 [details] [review]
Bug 33869: Matcher.t - indentation and whitespace changes

Test plan:
Run git diff --ignore-all-space --ignore-blank-lines HEAD~1.. t/Matcher.t; #no output expected

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 3 Marcel de Rooy 2023-05-31 13:10:13 UTC 
Created attachment 151874 [details] [review]
Bug 33869: Move Matcher.t to t/db_dependent

Test plan:
Run t/db_dependent/Matcher.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Matt Blenkinsop 2023-07-14 08:24:21 UTC 
Created attachment 153438 [details] [review]
Bug 33869: Matcher.t - use TestBuilder

Remove T::D::C

Test plan:
Run t/Matcher.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Comment 5 Matt Blenkinsop 2023-07-14 08:24:23 UTC 
Created attachment 153439 [details] [review]
Bug 33869: Matcher.t - indentation and whitespace changes

Test plan:
Run git diff --ignore-all-space --ignore-blank-lines HEAD~1.. t/Matcher.t; #no output expected

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Comment 6 Matt Blenkinsop 2023-07-14 08:24:26 UTC 
Created attachment 153440 [details] [review]
Bug 33869: Move Matcher.t to t/db_dependent

Test plan:
Run t/db_dependent/Matcher.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Comment 7 Jonathan Druart 2023-09-01 12:01:58 UTC 
Created attachment 155104 [details] [review]
Bug 33869: Matcher.t - use TestBuilder

Remove T::D::C

Test plan:
Run t/Matcher.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 8 Jonathan Druart 2023-09-01 12:02:01 UTC 
Created attachment 155105 [details] [review]
Bug 33869: Matcher.t - indentation and whitespace changes

Test plan:
Run git diff --ignore-all-space --ignore-blank-lines HEAD~1.. t/Matcher.t; #no output expected

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 9 Jonathan Druart 2023-09-01 12:02:03 UTC 
Created attachment 155106 [details] [review]
Bug 33869: Move Matcher.t to t/db_dependent

Test plan:
Run t/db_dependent/Matcher.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 10 Tomás Cohen Arazi (tcohen) 2023-09-01 14:10:15 UTC 
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 11 Fridolin Somers 2023-09-08 05:49:21 UTC 
Not backported to 23.05.x