Bug 33988 - Font awesome fa-gears on staff main page look wrong after upgrade to FA6
Summary: Font awesome fa-gears on staff main page look wrong after upgrade to FA6
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Lucas Gass
QA Contact: Testopia
URL:
Keywords:
Depends on: 32910
Blocks:
  Show dependency treegraph
 
Reported: 2023-06-12 17:53 UTC by Lucas Gass
Modified: 2023-12-12 21:32 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact: Caroline Cyr La Rose
Documentation submission: https://gitlab.com/koha-community/koha-manual/-/merge_requests/783
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 33988: Update gear icon on staff main page (1.34 KB, patch)
2023-06-12 17:56 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 33988: Update gear icon on staff main page (1.39 KB, patch)
2023-06-12 18:31 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33988: Update gear icon on staff main page (1.45 KB, patch)
2023-06-12 18:40 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass 2023-06-12 17:53:01 UTC
If you look at the gear icon on the intranet main page they don't look like the other icons after the FA6 upgrade. Seems to be missing a class.
Comment 1 Lucas Gass 2023-06-12 17:56:53 UTC
Created attachment 152278 [details] [review]
Bug 33988: Update gear icon on staff main page

To test.
1. On staff home page notice the gear icon necxt to 'Koha administration' looks different than the others/
2. Apply patch.
3. It looks better.
Comment 2 Owen Leonard 2023-06-12 18:31:19 UTC
Created attachment 152281 [details] [review]
Bug 33988: Update gear icon on staff main page

To test.
1. On staff home page notice the gear icon necxt to 'Koha
   administration' looks different than the others/
2. Apply patch.
3. It looks better.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Tomás Cohen Arazi 2023-06-12 18:40:52 UTC
Created attachment 152283 [details] [review]
Bug 33988: Update gear icon on staff main page

To test.
1. On staff home page notice the gear icon necxt to 'Koha
   administration' looks different than the others/
2. Apply patch.
3. It looks better.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 4 Tomás Cohen Arazi 2023-06-12 18:46:31 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 5 Martin Renvoize 2023-07-17 07:17:07 UTC
Enhancement depends on 32910. No backport for 23.05.x
Comment 6 Caroline Cyr La Rose 2023-12-12 21:32:40 UTC
I updated one screenshot that I found that shows those gears, but I'm not sure if it's somewhere else...