A minor regression snuck in with the FontAwesome upgrade (Bug 32910), probably from multiple rebases. We went back to "can_edit_item()" where we should have kept "can_edit_items_from( item.homebranch )". This causes an error when trying to do an item search in the staff interface: "Template process failed: undef error - The method Koha::Patron->can_edit_item is not covered by tests!"
Created attachment 152449 [details] [review] Bug 34042: Item search broken by FontAwesome upgrade This patch corrects a small regression in one of the templates for outputting item search results. The template lost the change made to it by Bug 33070: "Remove use of can_edit_items." The error meant that item searching wasn't working at all. To test, apply the patch and perform an item search in the staff interface. Results should be returned as expected.
Created attachment 152452 [details] [review] Bug 34042: Item search broken by FontAwesome upgrade This patch corrects a small regression in one of the templates for outputting item search results. The template lost the change made to it by Bug 33070: "Remove use of can_edit_items." The error meant that item searching wasn't working at all. To test, apply the patch and perform an item search in the staff interface. Results should be returned as expected. Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Created attachment 152483 [details] [review] Bug 34042: Item search broken by FontAwesome upgrade This patch corrects a small regression in one of the templates for outputting item search results. The template lost the change made to it by Bug 33070: "Remove use of can_edit_items." The error meant that item searching wasn't working at all. To test, apply the patch and perform an item search in the staff interface. Results should be returned as expected. Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 23.11. Nice work everyone, thanks!
Depends on Bug 32910 not in 23.05.x
Not required for 23.05.x