Bug 34298 - Duplicate existing orders is missing page section on order list
Summary: Duplicate existing orders is missing page section on order list
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Katrin Fischer
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-07-17 15:37 UTC by Katrin Fischer
Modified: 2024-12-05 15:50 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.03
Circulation function:


Attachments
Bug 34298: Add page-section to duplicated orders list (3.45 KB, patch)
2024-01-13 17:58 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 34298: Add page-section to duplicated orders list (3.50 KB, patch)
2024-01-17 21:12 UTC, David Nind
Details | Diff | Splinter Review
Bug 34298: Add page-section to duplicated orders list (3.60 KB, patch)
2024-01-19 10:46 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2023-07-17 15:37:56 UTC
When creating an order from an existing order (copy), on the third page, that lists the selected orders, the page section is missing on the table.
Comment 1 Katrin Fischer 2024-01-13 17:58:46 UTC
Created attachment 161018 [details] [review]
Bug 34298: Add page-section to duplicated orders list

When creating an order from an existing order (copy),
on the third page, the page section was  missing on the
table.

To test:
* Create a basket with an order, close the basket.
* Create a second basked
* Create a new order line using:
  "From existing orders (copy)"
* Search for your previous order and select it for copy - Next
* Select a fund - Duplicate orders
* Verify that the table with the order lines to create
  doesn't have the white background
* Apply patch
* Reload page - the table now should appear styled correctly
Comment 2 David Nind 2024-01-17 21:12:15 UTC
Created attachment 161119 [details] [review]
Bug 34298: Add page-section to duplicated orders list

When creating an order from an existing order (copy),
on the third page, the page section was  missing on the
table.

To test:
* Create a basket with an order, close the basket.
* Create a second basked
* Create a new order line using:
  "From existing orders (copy)"
* Search for your previous order and select it for copy - Next
* Select a fund - Duplicate orders
* Verify that the table with the order lines to create
  doesn't have the white background
* Apply patch
* Reload page - the table now should appear styled correctly

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Marcel de Rooy 2024-01-19 10:46:58 UTC
Created attachment 161204 [details] [review]
Bug 34298: Add page-section to duplicated orders list

When creating an order from an existing order (copy),
on the third page, the page section was  missing on the
table.

To test:
* Create a basket with an order, close the basket.
* Create a second basked
* Create a new order line using:
  "From existing orders (copy)"
* Search for your previous order and select it for copy - Next
* Select a fund - Duplicate orders
* Verify that the table with the order lines to create
  doesn't have the white background
* Apply patch
* Reload page - the table now should appear styled correctly

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Katrin Fischer 2024-01-29 11:28:24 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 5 Fridolin Somers 2024-02-01 14:05:59 UTC
Pushed to 23.11.x for 23.11.03