Bug 3431 - Catalog by itemtype report pulling from holdingbranch
Summary: Catalog by itemtype report pulling from holdingbranch
Alias: None
Product: Koha
Classification: Unclassified
Component: Reports (show other bugs)
Version: 3.6
Hardware: All All
: PATCH-Sent (DO NOT USE) normal (vote)
Assignee: Owen Leonard
QA Contact:
Depends on:
Reported: 2009-07-20 05:01 UTC by Chris Cormack
Modified: 2017-12-19 15:44 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:

Proposed fix (6.31 KB, patch)
2011-08-23 19:37 UTC, Owen Leonard
Details | Diff | Splinter Review
Fix for Bug 3431 - Catalog by itemtype report pulling from holdingbranch (6.32 KB, patch)
2011-12-12 08:48 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 01:10:25 UTC

---- Reported by maria.laude@liblime.com 2009-07-20 17:01:51 ----

Looks like report is pulling from holdingbranch, not homebranch as expected.  Either add description to report or change to homebranch, which is what typical user would expect.

--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:10 UTC  ---

This bug was previously known as _bug_ 3431 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3431

Actual time not defined. Setting to 0.0
The original reporter of this bug does not have
   an account here. Reassigning to the person who moved
   it here: chris@bigballofwax.co.nz.
   Previous reporter was maria.laude@liblime.com.
CC member maria.laude@liblime.com does not have an account here

Comment 1 Owen Leonard 2011-08-23 19:37:48 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2011-08-23 19:39:10 UTC
Oh, and here's why I clarified the description instead of changing the query to pull homebranch. I see this as a report of items *held* at your library, not owned. But it's okay, no one uses this report anyway.
Comment 3 Chris Cormack 2011-12-12 08:46:40 UTC
I agree this report is not used, but the changes made make it more useful to never use.
Will sign off
Comment 4 Chris Cormack 2011-12-12 08:48:34 UTC
Created attachment 6715 [details] [review]
Fix for Bug 3431 - Catalog by itemtype report pulling from holdingbranch

Plus several other fixes for this report no one uses:

- Clarifying titles and breadcrumbs
- Correcting terminology: branch -> library
- Sorting library select field by library name
- Displaying library name instead of code on output
- Sorting results by itemtype description
- Adding tablesorter to results

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Comment 5 Paul Poulain 2011-12-16 17:32:02 UTC
QA comment: clean code, passes perlcritic, clarify report

passed QA

patch pushed, please test