Bug 34332 - Syntax error in point of sale email template
Summary: Syntax error in point of sale email template
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Fines and fees (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Laura Escamilla
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 24381
Blocks: 34340
  Show dependency treegraph
 
Reported: 2023-07-20 18:21 UTC by Laura Escamilla
Modified: 2023-09-13 21:04 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.03,22.11.09


Attachments
Bug 34332: Removed extra parenthesis that was causing an error (1.03 KB, patch)
2023-07-20 18:25 UTC, Laura Escamilla
Details | Diff | Splinter Review
Bug 34332: Removed extra parenthesis that was causing an error (1.08 KB, patch)
2023-07-21 13:23 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Laura Escamilla 2023-07-20 18:21:43 UTC
To recreate: 
1. Configure your Koha to enable the point of sale system.
2. Go to Tools > Notices and Slips > Point of Sale Receipt
3. View the Email template - the error “file error - parse error - input text line 16: unexpected token ()) [% payment.library.branchname) | html %]” is showing
Comment 1 Laura Escamilla 2023-07-20 18:25:06 UTC
Created attachment 153741 [details] [review]
Bug 34332: Removed extra parenthesis that was causing an error

To test: 
1. Configure your Koha to enable the point of sale system.
2. Go to Tools > Notices and Slips > Point of Sale Receipt
3. View the Email template - the error “file error - parse error - input text line 16: unexpected token ()) [% payment.library.branchname) | html %]” is showing
4. Apply patch
5. Error has been resolved and email notices can be sent. 
6. Sign off!
Comment 2 Laura Escamilla 2023-07-20 20:10:58 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2023-07-21 13:23:16 UTC
Created attachment 153789 [details] [review]
Bug 34332: Removed extra parenthesis that was causing an error

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 4 Katrin Fischer 2023-07-21 13:24:37 UTC
Using my super-powers to put this straight to PQA. Thx Laura, it's always the little things!
Comment 5 Laura Escamilla 2023-07-21 13:33:41 UTC
(In reply to Katrin Fischer from comment #4)
> Using my super-powers to put this straight to PQA. Thx Laura, it's always
> the little things!

Thank you, Katrin!
Comment 6 Tomás Cohen Arazi 2023-07-21 20:15:35 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 7 Fridolin Somers 2023-08-04 02:07:29 UTC
Pushed to 23.05.x for 23.05.03
Comment 8 Pedro Amorim 2023-08-18 13:51:11 UTC
Nice work everyone!

Pushed to 22.11.x for next release