I am not able to reproduce Bug 34072 in Koha before the patch. In my test, the holds queue sidebar filter doesn't disappear, it just gets moved down to below the holds queue table when the browser window is below a certain width. This is to be expected with anything in the sidebar. I think the should be reverted. It has unwanted side-effects (changing margins around fieldsets and submit buttons) and doesn't seem to fix any bug as far as I can tell.
Created attachment 154651 [details] [review] Bug 34341: Revert Bug 34072: Holds queue search interface hidden on small screens This patch undoes the changes made by 34072 because they have had a more far-reaching effect than was expected. I have never been able to reproduce Bug 34072 before the patch. To test, apply the patch and rebuild the staff interface CSS. - Go to Circulation -> Holds queue - Try adjusting the width of the browser window to confirm that it is responsive at various widths. - When the viewport width is below 768 the page layout will adjust, and the contents of the sidebar will drop below the table of holds. This is consistent with other pages in the staff interface. - Check that the corrected CSS has resulted in a correction to the layout of submit buttons in forms: - For example, in Administration -> Cities and towns -> New city. - Before the patch there was no padding between the submit button and the white fieldset containing the form fields. - After the patch the correct padding has been restored.
Created attachment 154655 [details] [review] Bug 34341: Revert Bug 34072: Holds queue search interface hidden on small screens This patch undoes the changes made by 34072 because they have had a more far-reaching effect than was expected. I have never been able to reproduce Bug 34072 before the patch. To test, apply the patch and rebuild the staff interface CSS. - Go to Circulation -> Holds queue - Try adjusting the width of the browser window to confirm that it is responsive at various widths. - When the viewport width is below 768 the page layout will adjust, and the contents of the sidebar will drop below the table of holds. This is consistent with other pages in the staff interface. - Check that the corrected CSS has resulted in a correction to the layout of submit buttons in forms: - For example, in Administration -> Cities and towns -> New city. - Before the patch there was no padding between the submit button and the white fieldset containing the form fields. - After the patch the correct padding has been restored. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 154754 [details] [review] Bug 34341: Revert Bug 34072: Holds queue search interface hidden on small screens This patch undoes the changes made by 34072 because they have had a more far-reaching effect than was expected. I have never been able to reproduce Bug 34072 before the patch. To test, apply the patch and rebuild the staff interface CSS. - Go to Circulation -> Holds queue - Try adjusting the width of the browser window to confirm that it is responsive at various widths. - When the viewport width is below 768 the page layout will adjust, and the contents of the sidebar will drop below the table of holds. This is consistent with other pages in the staff interface. - Check that the corrected CSS has resulted in a correction to the layout of submit buttons in forms: - For example, in Administration -> Cities and towns -> New city. - Before the patch there was no padding between the submit button and the white fieldset containing the form fields. - After the patch the correct padding has been restored. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.11. Nice work everyone, thanks!
Pushed to 23.05.x for 23.05.04
Nice work everyone! Pushed to oldstable for 22.11.x