Bug 34443 - Spelling: Patron search pop-up Sort1: should be Sort 1:
Summary: Spelling: Patron search pop-up Sort1: should be Sort 1:
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Owen Leonard
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-07-29 21:40 UTC by Katrin Fischer
Modified: 2024-07-04 20:40 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.05,22.11.11
Circulation function:

Attachments
Bug 34443: Spelling: Patron search pop-up Sort1: should be Sort 1 (1.81 KB, patch)
2023-09-08 15:47 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 34443: Spelling: Patron search pop-up Sort1: should be Sort 1 (1.88 KB, patch)
2023-09-08 17:15 UTC, Laura Escamilla 		Details | Diff | Splinter Review
Bug 34443: Spelling: Patron search pop-up Sort1: should be Sort 1 (1.97 KB, patch)
2023-09-15 06:07 UTC, Marcel de Rooy 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2023-07-29 21:40:45 UTC 
The patron search pop-up (linking guarantors, adding roles to agreements) has 2 new search fields:

* Sort1:
* Sort2:

Both should be relabelled to match with the normal patron form:

* Sort 1:
* Sort 2:

It might also be nice to move them into a second column next to the other search options as currenlty they take up a lot of space in the small pop-up window.
Comment 1 Owen Leonard 2023-09-08 15:47:20 UTC 
Created attachment 155444 [details] [review]
Bug 34443: Spelling: Patron search pop-up Sort1: should be Sort 1

This patch instances of "Sort1" and "Sort2" being used
as labels in the interface, replacing the strings with "Sort 1" and
"Sort 2"

To test, apply the patch and test this page:

With the borrowerRelationship system preference populated, edit a
child record and click the "Add guarantor" button. There are two
fields in the form with the updated labels.
Comment 2 Laura Escamilla 2023-09-08 17:15:19 UTC 
Created attachment 155451 [details] [review]
Bug 34443: Spelling: Patron search pop-up Sort1: should be Sort 1

This patch instances of "Sort1" and "Sort2" being used
as labels in the interface, replacing the strings with "Sort 1" and
"Sort 2"

To test, apply the patch and test this page:

With the borrowerRelationship system preference populated, edit a
child record and click the "Add guarantor" button. There are two
fields in the form with the updated labels.

Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>
Comment 3 Marcel de Rooy 2023-09-15 06:07:52 UTC 
Created attachment 155633 [details] [review]
Bug 34443: Spelling: Patron search pop-up Sort1: should be Sort 1

This patch instances of "Sort1" and "Sort2" being used
as labels in the interface, replacing the strings with "Sort 1" and
"Sort 2"

To test, apply the patch and test this page:

With the borrowerRelationship system preference populated, edit a
child record and click the "Add guarantor" button. There are two
fields in the form with the updated labels.

Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Tomás Cohen Arazi (tcohen) 2023-09-15 14:58:46 UTC 
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 5 Fridolin Somers 2023-10-05 18:06:56 UTC 
Pushed to 23.05.x for 23.05.05
Comment 6 Jacob O'Mara 2023-10-17 13:37:36 UTC 
Nice work everyone!

Pushed to oldstable for 22.11.x