In the header search forms, we have a label which is associated with the form field, but in many cases the label doesn't have a "for" attribute. This is a problem for HTML validity and for accessibility.
Created attachment 154843 [details] [review] Bug 34624: Add "for" attribute to label in header search forms which lack it This patch adds a "for" label to header search forms labels which lack it. To test, apply the patch and test the affected pages to confirm that clicking the label corresponding to the active search form can be clicked to move cursor focus to that input field. As you activate each search form, the cursor focus will automatically be moved to the input. Click outside of the field to remove the focus, and then click the label to test that it is correctly tied to the field. - Staff interface home page: - Checkout, Check in, Renew, Search patrons, and Search catalog. - Acquisitions: Vendor search and orders search - Acquisitions -> Vendor search -> Vendor -> Contracts: Contract search - Acquisitions -> Vendor search -> Vendor -> Basket -> Add to basket -> From a suggestion: Search suggestions - Authorities: Main heading ($a only), Main heading, All headings, and Entire record. - Administration -> Budgets: Search funds - Administration -> Cities & towns: City search - Administration -> Currencies: Currencies search - Administration -> Desks: Search desks * With UseCirculationDesks enabled - Administration -> Patron categories: Search patron categories - Administration -> System preferences: Search system preferences - Administration -> Z39.50 servers -> Z39.50 server search - Cataloging: Cataloging search - E-resource management: Search agreements, Search licenses, Search packages, and Search titles * With ERMModule enabled - Patrons -> Search patrons - Serials: Search subscriptions - Tools -> Notices & slips: Search notices
Created attachment 154879 [details] [review] Bug 34624: Add "for" attribute to label in header search forms which lack it This patch adds a "for" label to header search forms labels which lack it. To test, apply the patch and test the affected pages to confirm that clicking the label corresponding to the active search form can be clicked to move cursor focus to that input field. As you activate each search form, the cursor focus will automatically be moved to the input. Click outside of the field to remove the focus, and then click the label to test that it is correctly tied to the field. - Staff interface home page: - Checkout, Check in, Renew, Search patrons, and Search catalog. - Acquisitions: Vendor search and orders search - Acquisitions -> Vendor search -> Vendor -> Contracts: Contract search - Acquisitions -> Vendor search -> Vendor -> Basket -> Add to basket -> From a suggestion: Search suggestions - Authorities: Main heading ($a only), Main heading, All headings, and Entire record. - Administration -> Budgets: Search funds - Administration -> Cities & towns: City search - Administration -> Currencies: Currencies search - Administration -> Desks: Search desks * With UseCirculationDesks enabled - Administration -> Patron categories: Search patron categories - Administration -> System preferences: Search system preferences - Administration -> Z39.50 servers -> Z39.50 server search - Cataloging: Cataloging search - E-resource management: Search agreements, Search licenses, Search packages, and Search titles * With ERMModule enabled - Patrons -> Search patrons - Serials: Search subscriptions - Tools -> Notices & slips: Search notices Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
I wonder if we should/could just merge all these *-search.inc files into a single one.
Created attachment 155150 [details] [review] Bug 34624: Add "for" attribute to label in header search forms which lack it This patch adds a "for" label to header search forms labels which lack it. To test, apply the patch and test the affected pages to confirm that clicking the label corresponding to the active search form can be clicked to move cursor focus to that input field. As you activate each search form, the cursor focus will automatically be moved to the input. Click outside of the field to remove the focus, and then click the label to test that it is correctly tied to the field. - Staff interface home page: - Checkout, Check in, Renew, Search patrons, and Search catalog. - Acquisitions: Vendor search and orders search - Acquisitions -> Vendor search -> Vendor -> Contracts: Contract search - Acquisitions -> Vendor search -> Vendor -> Basket -> Add to basket -> From a suggestion: Search suggestions - Authorities: Main heading ($a only), Main heading, All headings, and Entire record. - Administration -> Budgets: Search funds - Administration -> Cities & towns: City search - Administration -> Currencies: Currencies search - Administration -> Desks: Search desks * With UseCirculationDesks enabled - Administration -> Patron categories: Search patron categories - Administration -> System preferences: Search system preferences - Administration -> Z39.50 servers -> Z39.50 server search - Cataloging: Cataloging search - E-resource management: Search agreements, Search licenses, Search packages, and Search titles * With ERMModule enabled - Patrons -> Search patrons - Serials: Search subscriptions - Tools -> Notices & slips: Search notices Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Created attachment 155286 [details] [review] Bug 34624: (follow-up) fix broken <span>
QA in progress: code looks good, test plan lists all the relevant pages.
All good except "- Serials: Search subscriptions" There is no "for", where should it point to? On page load, focus is on ISSN, should it be the same or does Title makes more sense there?
Created attachment 155394 [details] [review] Bug 34624: (follow-up) Add "for" attribute to serials-search.inc label
Created attachment 155412 [details] [review] Bug 34624: Add "for" attribute to label in header search forms which lack it This patch adds a "for" label to header search forms labels which lack it. To test, apply the patch and test the affected pages to confirm that clicking the label corresponding to the active search form can be clicked to move cursor focus to that input field. As you activate each search form, the cursor focus will automatically be moved to the input. Click outside of the field to remove the focus, and then click the label to test that it is correctly tied to the field. - Staff interface home page: - Checkout, Check in, Renew, Search patrons, and Search catalog. - Acquisitions: Vendor search and orders search - Acquisitions -> Vendor search -> Vendor -> Contracts: Contract search - Acquisitions -> Vendor search -> Vendor -> Basket -> Add to basket -> From a suggestion: Search suggestions - Authorities: Main heading ($a only), Main heading, All headings, and Entire record. - Administration -> Budgets: Search funds - Administration -> Cities & towns: City search - Administration -> Currencies: Currencies search - Administration -> Desks: Search desks * With UseCirculationDesks enabled - Administration -> Patron categories: Search patron categories - Administration -> System preferences: Search system preferences - Administration -> Z39.50 servers -> Z39.50 server search - Cataloging: Cataloging search - E-resource management: Search agreements, Search licenses, Search packages, and Search titles * With ERMModule enabled - Patrons -> Search patrons - Serials: Search subscriptions - Tools -> Notices & slips: Search notices Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 155413 [details] [review] Bug 34624: (follow-up) fix broken <span> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 155414 [details] [review] Bug 34624: (follow-up) Add "for" attribute to serials-search.inc label Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Looking good, thanks Owen. QA scripts happy, no regressions found. Passing QA
Great, thanks all :)
Pushed to master for 23.11. Nice work everyone, thanks!
Does not apply on 23.05.x, surely because not having Bug 32910
Is there interest in having this backported?
It would be great to see this accessibility improvement backported.. but I've not actually seen it hit am accessibility assessment report yet.. so it really depends if it's much work or not.. I'm sure we could wait for it here at least [U+1F609]
Created attachment 157070 [details] [review] Bug 34624: [23.05.x] Add "for" attribute to label in header search forms which lack it This patch adds a "for" label to header search forms labels which lack it. To test, apply the patch and test the affected pages to confirm that clicking the label corresponding to the active search form can be clicked to move cursor focus to that input field. As you activate each search form, the cursor focus will automatically be moved to the input. Click outside of the field to remove the focus, and then click the label to test that it is correctly tied to the field. - Staff interface home page: - Checkout, Check in, Renew, Search patrons, and Search catalog. - Acquisitions: Vendor search and orders search - Acquisitions -> Vendor search -> Vendor -> Contracts: Contract search - Acquisitions -> Vendor search -> Vendor -> Basket -> Add to basket -> From a suggestion: Search suggestions - Authorities: Main heading ($a only), Main heading, All headings, and Entire record. - Administration -> Budgets: Search funds - Administration -> Cities & towns: City search - Administration -> Currencies: Currencies search - Administration -> Desks: Search desks * With UseCirculationDesks enabled - Administration -> Patron categories: Search patron categories - Administration -> System preferences: Search system preferences - Administration -> Z39.50 servers -> Z39.50 server search - Cataloging: Cataloging search - E-resource management: Search agreements, Search licenses, Search packages, and Search titles * With ERMModule enabled - Patrons -> Search patrons - Serials: Search subscriptions - Tools -> Notices & slips: Search notices
Pushed to 23.05.x for 23.05.06