Bug 34706 - Capitalization: Cas login
Summary: Capitalization: Cas login
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: David Nind
QA Contact: Emily Lamancusa (emlam)
URL:
Keywords: Academy, Sandbox
Depends on:
Blocks:
 
Reported: 2023-09-04 14:32 UTC by Katrin Fischer
Modified: 2024-09-12 06:35 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes a capitalization error. CAS is an abbreviation, and should be CAS on the login form (used when casAuthentication is enabled and configured).
Version(s) released in:
24.11.00,24.05.02,23.11.07
Circulation function:

Attachments
Bug 34706: Fix capitalization - Cas to CAS (1.12 KB, patch)
2024-06-15 10:17 UTC, David Nind 		Details | Diff | Splinter Review
Bug 34706: Fix capitalization - Cas to CAS (1.17 KB, patch)
2024-06-17 20:00 UTC, Sam Lau 		Details | Diff | Splinter Review
Bug 34706: Fix capitalization - Cas to CAS (1.24 KB, patch)
2024-06-18 20:51 UTC, Emily Lamancusa (emlam) 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2023-09-04 14:32:22 UTC 
CAS is an abbreviation and should always be spelled in capital letters. There is a wrong string on the staff interface login page:

koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt:158
Cas login
Comment 1 David Nind 2024-06-15 10:17:29 UTC 
Created attachment 167775 [details] [review]
Bug 34706: Fix capitalization - Cas to CAS

CAS is an abbreviation and should use capital letters.

Test plan:
1. Enable the casAuthentication system preference.
2. Logout and view the login form.
3. Note that it says "Cas login".
4. Apply the patch.
5. Refresh the login page.
6. Note that it now says "CAS login".
7. Sign off.

Signed-off-by: David Nind <david@davidnind.com>
Comment 2 Sam Lau 2024-06-17 20:00:52 UTC 
Created attachment 167803 [details] [review]
Bug 34706: Fix capitalization - Cas to CAS

CAS is an abbreviation and should use capital letters.

Test plan:
1. Enable the casAuthentication system preference.
2. Logout and view the login form.
3. Note that it says "Cas login".
4. Apply the patch.
5. Refresh the login page.
6. Note that it now says "CAS login".
7. Sign off.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Sam Lau <samalau@gmail.com>
Comment 3 Emily Lamancusa (emlam) 2024-06-18 20:51:41 UTC 
Created attachment 167873 [details] [review]
Bug 34706: Fix capitalization - Cas to CAS

CAS is an abbreviation and should use capital letters.

Test plan:
1. Enable the casAuthentication system preference.
2. Logout and view the login form.
3. Note that it says "Cas login".
4. Apply the patch.
5. Refresh the login page.
6. Note that it now says "CAS login".
7. Sign off.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Sam Lau <samalau@gmail.com>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Comment 4 Katrin Fischer 2024-06-21 12:39:54 UTC 
That feels so much better, thank you!
Comment 5 Katrin Fischer 2024-06-21 13:04:03 UTC 
Pushed for 24.11!

Well done everyone, thank you!
Comment 6 Lucas Gass (lukeg) 2024-07-18 19:37:35 UTC 
Backported to 24.05.x for upcoming 24.05.02
Comment 7 Fridolin Somers 2024-07-19 09:08:34 UTC 
Pushed to 23.11.x for 23.11.07
Comment 8 Wainui Witika-Park 2024-09-12 06:35:04 UTC 
Not backporting to 23.05.x unless requested