Bug 34791 - CookieConsent preference should hint that there's HTML content blocks available for customisation
Summary: CookieConsent preference should hint that there's HTML content blocks availab...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Martin Renvoize (ashimema)
QA Contact: Marcel de Rooy
URL:
Keywords: Academy, rel_23_11_candidate, Sandbox
Depends on: 27378
Blocks:
  Show dependency tree / graph
 
Reported: 2023-09-14 14:15 UTC by Martin Renvoize (ashimema)
Modified: 2024-07-04 20:37 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00
Circulation function:

Attachments
Bug 34791: Add links to HTML Customizations to CookieConsent preferences (1.89 KB, patch)
2023-09-14 14:31 UTC, Martin Renvoize (ashimema) 		Details | Diff | Splinter Review
Bug 34791: Add links to HTML Customizations to CookieConsent preferences (1.95 KB, patch)
2023-11-08 20:50 UTC, Lucas Gass (lukeg) 		Details | Diff | Splinter Review
Bug 34791: Add links to HTML Customizations to CookieConsent preferences (2.04 KB, patch)
2023-11-10 10:42 UTC, Marcel de Rooy 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize (ashimema) 2023-09-14 14:15:07 UTC 
One can enable/disable the cookieConsent feature from the system preferences and add tracking cookies to the mix there, but there's not hint to say you can customise the appearance using the HTML Customisations.
Comment 1 Martin Renvoize (ashimema) 2023-09-14 14:31:25 UTC 
Created attachment 155615 [details] [review]
Bug 34791: Add links to HTML Customizations to CookieConsent preferences

This patch simply adds a note to the CookieConsent and CookieConsentedJS
system preferences to link to the HTML customizations page and hint at
which customization should be used to affect the components governed by
the preferences.
Comment 2 Lucas Gass (lukeg) 2023-11-08 20:50:42 UTC 
Created attachment 158674 [details] [review]
Bug 34791: Add links to HTML Customizations to CookieConsent preferences

This patch simply adds a note to the CookieConsent and CookieConsentedJS
system preferences to link to the HTML customizations page and hint at
which customization should be used to affect the components governed by
the preferences.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 3 Marcel de Rooy 2023-11-10 10:42:11 UTC 
Created attachment 158798 [details] [review]
Bug 34791: Add links to HTML Customizations to CookieConsent preferences

This patch simply adds a note to the CookieConsent and CookieConsentedJS
system preferences to link to the HTML customizations page and hint at
which customization should be used to affect the components governed by
the preferences.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Tomás Cohen Arazi (tcohen) 2023-11-10 14:02:19 UTC 
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 5 Fridolin Somers 2023-11-11 08:03:19 UTC 
Depends on Bug 27378 not in 23.05.x