To continue the process started by Bug 32507, this patch will update several templates in the OPAC so that they use a template wrapper for breadcrumbs. - errors/errorpage.tt - opac-account.tt - opac-auth.tt - opac-curbside-pickups.tt - opac-discharge.tt - opac-holdshistory.tt - opac-illrequests.tt - opac-memberentry-update-submitted.tt - opac-memberentry.tt - opac-messaging.tt - opac-passwd.tt - opac-password-recovery.tt - opac-patron-consent.tt - opac-privacy.tt - opac-readingrecord.tt - opac-recalls.tt - opac-reset-password.tt - opac-routing-lists.tt - opac-search-history.tt - opac-shelves.tt - opac-tags.tt - opac-user.tt
Created attachment 155949 [details] [review] Bug 34849: Use template wrapper for breadcrumbs: OPAC part 1 This patch updates several OPAC templates so that they use a new WRAPPER for displaying breadcrumbs. The patch contains a minor CSS update, so you will have to rebuild the OPAC CSS for testings. Apply the patch and log in to the OPAC. Test each of the following pages and their variations. Breadcrumbs should look correct, and each link should be correct: - User summary - Charges - Personal details - Submit changes - Consents (with PrivacyPolicyConsent enabled) - Tags - Change password - Submit password change - Search history - Test when logged in and when not logged in - Checkout history - Privacy - Holds history - Recalls history - Purchase suggestions - Also test as a logged-out user with AnonSuggestions enabled. - Messaging (with EnhancedMessagingPreferences and EnhancedMessagingPreferencesOPAC enabled). - Lists - View private list - View public list - Edit list - Share list - Submit invitation - Create list - View list contents - ILL requests - Curbside pickups - Error page: Navigate to a non-existent page
Created attachment 155951 [details] [review] Bug 34849: Use template wrapper for breadcrumbs: OPAC part 1 This patch updates several OPAC templates so that they use a new WRAPPER for displaying breadcrumbs. The patch contains a minor CSS update, so you will have to rebuild the OPAC CSS for testings. Apply the patch and log in to the OPAC. Test each of the following pages and their variations. Breadcrumbs should look correct, and each link should be correct: - User summary - Charges - Personal details - Submit changes - Consents (with PrivacyPolicyConsent enabled) - Tags - Change password - Submit password change - Search history - Test when logged in and when not logged in - Checkout history - Privacy - Holds history - Recalls history - Messaging (with EnhancedMessagingPreferences and EnhancedMessagingPreferencesOPAC enabled). - Lists - View private list - View public list - Edit list - Share list - Submit invitation - Create list - View list contents - Routing lists (with RoutingSerials enabled) - Ask for a discharge (with useDischarge enabled) - ILL requests - Curbside pickups - Error page: Navigate to a non-existent page
Created attachment 155959 [details] [review] Bug 34849: Use template wrapper for breadcrumbs: OPAC part 1 This patch updates several OPAC templates so that they use a new WRAPPER for displaying breadcrumbs. The patch contains a minor CSS update, so you will have to rebuild the OPAC CSS for testings. Apply the patch and log in to the OPAC. Test each of the following pages and their variations. Breadcrumbs should look correct, and each link should be correct: - User summary - Charges - Personal details - Submit changes - Consents (with PrivacyPolicyConsent enabled) - Tags - Change password - Submit password change - Search history - Test when logged in and when not logged in - Checkout history - Privacy - Holds history - Recalls history - Messaging (with EnhancedMessagingPreferences and EnhancedMessagingPreferencesOPAC enabled). - Lists - View private list - View public list - Edit list - Share list - Submit invitation - Create list - View list contents - Routing lists (with RoutingSerials enabled) - Ask for a discharge (with useDischarge enabled) - ILL requests - Curbside pickups - Error page: Navigate to a non-existent page
Every page except "Routing lists" has the correct links in the breadcrumb and everything looks correct. For "Routing lists" though, in the breadcrumb, the link to the user account links to .../cgi-bin/koha/opac-routing-lists.pl instead of .../cgi-bin/koha/opac-user.pl
Also, qa complained about some lines: Processing files before patches Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt line 346. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt line 349. |========================>| 24 / 24 (100.00%) Processing files after patches Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt line 341. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt line 344. |========================>| 24 / 24 (100.00%) Though everything still checked out OK, so I don't know if it's important.
Created attachment 157054 [details] [review] Bug 34849: Use template wrapper for breadcrumbs: OPAC part 1 This patch updates several OPAC templates so that they use a new WRAPPER for displaying breadcrumbs. The patch contains a minor CSS update, so you will have to rebuild the OPAC CSS for testings. Apply the patch and log in to the OPAC. Test each of the following pages and their variations. Breadcrumbs should look correct, and each link should be correct: - User summary - Charges - Personal details - Submit changes - Consents (with PrivacyPolicyConsent enabled) - Tags - Change password - Submit password change - Search history - Test when logged in and when not logged in - Checkout history - Privacy - Holds history - Recalls history - Messaging (with EnhancedMessagingPreferences and EnhancedMessagingPreferencesOPAC enabled). - Lists - View private list - View public list - Edit list - Share list - Submit invitation - Create list - View list contents - Routing lists (with RoutingSerials enabled) - Ask for a discharge (with useDischarge enabled) - ILL requests - Curbside pickups - Error page: Navigate to a non-existent page
Created attachment 157064 [details] [review] Bug 34849: Use template wrapper for breadcrumbs: OPAC part 1 This patch updates several OPAC templates so that they use a new WRAPPER for displaying breadcrumbs. The patch contains a minor CSS update, so you will have to rebuild the OPAC CSS for testings. Apply the patch and log in to the OPAC. Test each of the following pages and their variations. Breadcrumbs should look correct, and each link should be correct: - User summary - Charges - Personal details - Submit changes - Consents (with PrivacyPolicyConsent enabled) - Tags - Change password - Submit password change - Search history - Test when logged in and when not logged in - Checkout history - Privacy - Holds history - Recalls history - Messaging (with EnhancedMessagingPreferences and EnhancedMessagingPreferencesOPAC enabled). - Lists - View private list - View public list - Edit list - Share list - Submit invitation - Create list - View list contents - Routing lists (with RoutingSerials enabled) - Ask for a discharge (with useDischarge enabled) - ILL requests - Curbside pickups - Error page: Navigate to a non-existent page Signed-off-by: Philip Orr <philip.orr@lmscloud.de>
Created attachment 157154 [details] [review] Bug 34849: Use template wrapper for breadcrumbs: OPAC part 1 This patch updates several OPAC templates so that they use a new WRAPPER for displaying breadcrumbs. The patch contains a minor CSS update, so you will have to rebuild the OPAC CSS for testings. Apply the patch and log in to the OPAC. Test each of the following pages and their variations. Breadcrumbs should look correct, and each link should be correct: - User summary - Charges - Personal details - Submit changes - Consents (with PrivacyPolicyConsent enabled) - Tags - Change password - Submit password change - Search history - Test when logged in and when not logged in - Checkout history - Privacy - Holds history - Recalls history - Messaging (with EnhancedMessagingPreferences and EnhancedMessagingPreferencesOPAC enabled). - Lists - View private list - View public list - Edit list - Share list - Submit invitation - Create list - View list contents - Routing lists (with RoutingSerials enabled) - Ask for a discharge (with useDischarge enabled) - ILL requests - Curbside pickups - Error page: Navigate to a non-existent page Signed-off-by: Philip Orr <philip.orr@lmscloud.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.11. Nice work everyone, thanks!
This is more an enhancement, not backported to 23.05.x