Bug 34872 - Cart pop-up is missing page section
Summary: Cart pop-up is missing page section
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Katrin Fischer
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-09-21 20:58 UTC by Katrin Fischer
Modified: 2024-02-01 13:54 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.03
Circulation function:

Attachments
Bug 34872: Add page-section to cart pop-up in staff interface (36.40 KB, patch)
2024-01-13 16:00 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Bug 34872: Add page-section to cart pop-up in staff interface (36.45 KB, patch)
2024-01-13 17:12 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 34872: Add page-section to cart pop-up in staff interface (36.54 KB, patch)
2024-01-19 10:42 UTC, Marcel de Rooy 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2023-09-21 20:58:52 UTC 
The cart pop-up in the staff interface is missing a page section on the table.
Comment 1 Katrin Fischer 2024-01-13 16:00:08 UTC 
Created attachment 161015 [details] [review]
Bug 34872: Add page-section to cart pop-up in staff interface

This adds the page-section class to the tables in the cart pop-up
in the staff interface.

To test:
* Search for records in the staff interface and add some to the cart
* Open the cart, review the normal and brief view
* Apply patch
* Review normal and brief view again - tables/sections should now
  have the white background.
Comment 2 Owen Leonard 2024-01-13 17:12:51 UTC 
Created attachment 161017 [details] [review]
Bug 34872: Add page-section to cart pop-up in staff interface

This adds the page-section class to the tables in the cart pop-up
in the staff interface.

To test:
* Search for records in the staff interface and add some to the cart
* Open the cart, review the normal and brief view
* Apply patch
* Review normal and brief view again - tables/sections should now
  have the white background.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Marcel de Rooy 2024-01-19 10:42:32 UTC 
Created attachment 161202 [details] [review]
Bug 34872: Add page-section to cart pop-up in staff interface

This adds the page-section class to the tables in the cart pop-up
in the staff interface.

To test:
* Search for records in the staff interface and add some to the cart
* Open the cart, review the normal and brief view
* Apply patch
* Review normal and brief view again - tables/sections should now
  have the white background.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Katrin Fischer 2024-01-29 11:28:31 UTC 
Pushed for 24.05!

Well done everyone, thank you!
Comment 5 Fridolin Somers 2024-02-01 13:54:13 UTC 
Pushed to 23.11.x for 23.11.03