Bug 34921 - Tabs on Additional Content page need space above
Summary: Tabs on Additional Content page need space above
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-09-26 15:41 UTC by Martin Renvoize (ashimema)
Modified: 2024-06-26 16:03 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.05,22.11.11
Circulation function:

Attachments
Screenshot (47.74 KB, image/png)
2023-09-26 15:42 UTC, Martin Renvoize (ashimema) 		Details
Bug 34921: Tabs on Additional Content page need space above (1.19 KB, patch)
2023-09-27 12:40 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 34921: Tabs on Additional Content page need space above (1.25 KB, patch)
2023-09-27 13:14 UTC, Martin Renvoize (ashimema) 		Details | Diff | Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize (ashimema) 2023-09-26 15:41:21 UTC 
The fieldset followed by tabs for translations on the Additional content/News/HTML Customizations pages lacks some spacing above the tabs.
Comment 1 Martin Renvoize (ashimema) 2023-09-26 15:42:48 UTC 
Created attachment 156236 [details]
Screenshot
Comment 2 Owen Leonard 2023-09-27 12:40:46 UTC 
Created attachment 156286 [details] [review]
Bug 34921: Tabs on Additional Content page need space above

This patch adds a separator element, <hr /> between the additional
contents form and the tabs for visual clarity. Using an element is a
little hackish but it's a simple solution.

To test, apply the patch and go to Tools -> News -> New entry.

There should be a clear gap between the top form and the tabs below.
Comment 3 Martin Renvoize (ashimema) 2023-09-27 13:14:03 UTC 
Created attachment 156288 [details] [review]
Bug 34921: Tabs on Additional Content page need space above

This patch adds a separator element, <hr /> between the additional
contents form and the tabs for visual clarity. Using an element is a
little hackish but it's a simple solution.

To test, apply the patch and go to Tools -> News -> New entry.

There should be a clear gap between the top form and the tabs below.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize (ashimema) 2023-09-27 13:14:38 UTC 
Your right.. it feels a little hacky, but is also the least intrusive and least likely to have unexpected side effects.

Passing QA
Comment 5 Tomás Cohen Arazi (tcohen) 2023-10-04 20:44:09 UTC 
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 6 Fridolin Somers 2023-10-06 01:00:38 UTC 
Pushed to 23.05.x for 23.05.05
Comment 7 Matt Blenkinsop 2023-10-17 17:36:15 UTC 
Nice work everyone!

Pushed to oldstable for 22.11.x