Bug 35232 - Misspelled ID breaks label on patron lists form
Summary: Misspelled ID breaks label on patron lists form
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Eric Garcia
QA Contact: Lucas Gass (lukeg)
URL:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2023-11-02 16:22 UTC by Owen Leonard
Modified: 2024-12-02 10:08 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00,24.05.06,23.11.11
Circulation function:


Attachments
Bug 35232: Fix typo on list.tt (1.47 KB, patch)
2024-06-25 15:49 UTC, Eric Garcia
Details | Diff | Splinter Review
Bug 35232: Fix typo on list.tt (1.52 KB, patch)
2024-06-26 03:45 UTC, Phil Ringnalda
Details | Diff | Splinter Review
Bug 35232: Fix typo on list.tt (1.57 KB, patch)
2024-06-26 13:08 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-11-02 16:22:17 UTC
- Go to Patron lists and add patrons to a list.
- Click the "Add multiple patrons" link
- Clicking the "Borrowernumbers" label doesn't trigger the corresponding radio button

The input's id attribute is "add_by_borrwernumbers" instead of "add_by_borrowernumbers"
Comment 1 Eric Garcia 2024-06-25 15:49:06 UTC Comment hidden (obsolete)
Comment 2 Phil Ringnalda 2024-06-26 03:45:57 UTC
Created attachment 168118 [details] [review]
Bug 35232: Fix typo on list.tt

1. Go to Patron lists and add patrons to a list.
2. Click the "Add multiple patrons" link
3. Clicking the "Borrowernumbers" label doesn't trigger the corresponding radio button
4. Apply patch
5. Attempt steps 1-3
6. Sign off :)

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Comment 3 Lucas Gass (lukeg) 2024-06-26 13:08:12 UTC
Created attachment 168141 [details] [review]
Bug 35232: Fix typo on list.tt

1. Go to Patron lists and add patrons to a list.
2. Click the "Add multiple patrons" link
3. Clicking the "Borrowernumbers" label doesn't trigger the corresponding radio button
4. Apply patch
5. Attempt steps 1-3
6. Sign off :)

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 4 Lucas Gass (lukeg) 2024-06-26 13:08:29 UTC
Thank you, Eric!
Comment 5 Katrin Fischer 2024-06-27 12:06:25 UTC
Pushed for 24.11!

Well done everyone, thank you!
Comment 6 Lucas Gass (lukeg) 2024-11-18 16:51:52 UTC
Backported to 24.05.x for upcoming 24.05.06
Comment 7 Fridolin Somers 2024-12-02 10:08:05 UTC
Pushed to 23.11.x for 23.11.11