35240 – Missing form field ids in rotating collection edit form

Bug 35240 - Missing form field ids in rotating collection edit form

Summary: Missing form field ids in rotating collection edit form

Status:	Pushed to oldstable

Alias:	None

Product:	Koha
Classification:	Unclassified
Component:	Templates (show other bugs)
Version:	Main
Hardware:	All All

Importance:	P5 - low minor
Assignee:	Eric Garcia
QA Contact:	Testopia

URL:
Keywords:	Academy, accessibility

Depends on:
Blocks:

Reported:	2023-11-02 18:14 UTC by Owen Leonard
Modified:	2024-07-23 10:46 UTC (History)
CC List:	5 users (show)

See Also:
Change sponsored?:	---
Patch complexity:	Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:	This adds missing IDs to the rotating collections edit form (Tools > Rotating collections > edit a rotating collection (Actions > Edit)).
Version(s) released in:	24.11.00,24.05.02,23.11.07
Circulation function:

Attachments
Bug 35240: Add missing IDs to input (2.70 KB, patch) 2024-06-25 17:21 UTC, Eric Garcia	Details \| Diff \| Splinter Review
Bug 35240: Add missing IDs to input (2.75 KB, patch) 2024-06-26 13:58 UTC, Owen Leonard	Details \| Diff \| Splinter Review
Bug 35240: Add missing IDs to input (2.80 KB, patch) 2024-06-26 17:47 UTC, Nick Clemens (kidclamp)	Details \| Diff \| Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Owen Leonard 2023-11-02 18:14:14 UTC

Tools ->  Rotating collections -> Edit collection:

This form already has valid labels but the form fields do not have matching ids.

Comment 1 Eric Garcia 2024-06-25 17:21:00 UTC Comment hidden (obsolete)

Created attachment 168087 [details] [review]
Bug 35240: Add missing IDs to input

1. Tools -> Rotating collections -> Edit collection
2. Use browser dev tools to notice that the inputs don't have matching IDs
3. Apply patch
4. Do step 2 again and notice IDs are no longer missing.
5. Sign off :)

Comment 2 Owen Leonard 2024-06-26 13:58:34 UTC

Created attachment 168147 [details] [review]
Bug 35240: Add missing IDs to input

1. Tools -> Rotating collections -> Edit collection
2. Use browser dev tools to notice that the inputs don't have matching
   IDs
3. Apply patch
4. Do step 2 again and notice IDs are no longer missing.
5. Sign off :)

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Comment 3 Owen Leonard 2024-06-26 13:59:51 UTC

It's not necessary to use dev tools to test this patch. Form fields with IDs that correctly match their labels will receive focus when the corresponding label is clicked.

Comment 4 Nick Clemens (kidclamp) 2024-06-26 17:47:10 UTC

Created attachment 168173 [details] [review]
Bug 35240: Add missing IDs to input

1. Tools -> Rotating collections -> Edit collection
2. Use browser dev tools to notice that the inputs don't have matching
   IDs
3. Apply patch
4. Do step 2 again and notice IDs are no longer missing.
5. Sign off :)

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Comment 5 Katrin Fischer 2024-06-27 09:52:25 UTC

Pushed for 24.11!

Well done everyone, thank you!

Comment 6 Lucas Gass (lukeg) 2024-07-19 15:20:46 UTC

Backported to 24.05.x for upcoming 24.05.02

Comment 7 Fridolin Somers 2024-07-22 09:48:45 UTC

Pushed to 23.11.x for 23.11.07