The OPAC self registration confirmation page has its content displayed without any margin to the left, directly at the outer line of the content box. This doesn't look very nice and could be improved.
I don't think I can reproduce this problem. Can you attach a screenshot?
Created attachment 158542 [details] Slef registration confirmation page Tested without email verification.
Can confirm that I get the same results using Firefox (Developer Edition) and Chromium on Ubuntu 22.04.
Created attachment 158553 [details] [review] Bug 35262: Improve OPAC self registration confirmation page This patch corrects logic in the OPAC self registration confirmation template so that the right column markup is shown when various combinations of OpacNav, OpacNavBottom, and OpacNavRight are displayed. To test, apply the patch and enable the PatronSelfRegistration system preference, and deactivate the PatronSelfRegistrationVerifyByEmail preference. - Go to the OPAC and start the process of registering online. - Fill in the form and submit it. - On the registration confirmation page, check that the layout looks correct. - Test with the presence of various combinations of OpacNav, OpacNavBottom, and OpacNavRight HTML customizations.
Created attachment 158558 [details] [review] Bug 35262: Improve OPAC self registration confirmation page This patch corrects logic in the OPAC self registration confirmation template so that the right column markup is shown when various combinations of OpacNav, OpacNavBottom, and OpacNavRight are displayed. To test, apply the patch and enable the PatronSelfRegistration system preference, and deactivate the PatronSelfRegistrationVerifyByEmail preference. - Go to the OPAC and start the process of registering online. - Fill in the form and submit it. - On the registration confirmation page, check that the layout looks correct. - Test with the presence of various combinations of OpacNav, OpacNavBottom, and OpacNavRight HTML customizations. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 158560 [details] [review] Bug 35262: Improve OPAC self registration confirmation page This patch corrects logic in the OPAC self registration confirmation template so that the right column markup is shown when various combinations of OpacNav, OpacNavBottom, and OpacNavRight are displayed. To test, apply the patch and enable the PatronSelfRegistration system preference, and deactivate the PatronSelfRegistrationVerifyByEmail preference. - Go to the OPAC and start the process of registering online. - Fill in the form and submit it. - On the registration confirmation page, check that the layout looks correct. - Test with the presence of various combinations of OpacNav, OpacNavBottom, and OpacNavRight HTML customizations. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.11. Nice work everyone, thanks!
Small enhancement, I choose to backport Pushed to 23.05.x for 23.05.06
Nice work everyone! Pushed to 22.11.x for next release