Bug 35351 - Adjust basket details template to avoid showing empty page-section
Summary: Adjust basket details template to avoid showing empty page-section
Status: Passed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low trivial (vote)
Assignee: Owen Leonard
QA Contact: Emily Lamancusa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-11-16 14:10 UTC by Owen Leonard
Modified: 2024-01-31 21:49 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This enhancement removes the empty white section in acquisitions for a basket with no orders.
Version(s) released in:


Attachments
Bug 35351: Adjust basket details template to avoid showing empty page-section (2.73 KB, patch)
2023-11-16 14:25 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 35351: Adjust basket details template to avoid showing empty page-section (2.78 KB, patch)
2023-12-11 20:22 UTC, David Nind
Details | Diff | Splinter Review
Bug 35351: Adjust basket details template to avoid showing empty page-section (2.85 KB, patch)
2024-01-25 18:00 UTC, Emily Lamancusa
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-11-16 14:10:27 UTC
We shouldn't show an empty page-section div when there are no orders to show.
Comment 1 Owen Leonard 2023-11-16 14:25:11 UTC
Created attachment 159052 [details] [review]
Bug 35351: Adjust basket details template to avoid showing empty page-section

This patch makes a minor change to the markup of the basket details page
so that we don't display an empty div.page-section when there are no
orders.

Note: This patch includes whitespace changes, so please ignore
whitespace when viewing the diff.

To test, apply the patch and go to Acquisitions.

- Search for a vendor and add a basket if necessary.
- View the details of an empty basket.
- Under the "General information" or "Settings" sections there should be
  no empty white box.
- View the details of a basket which has orders (using the "Add to
  basket" process if necessary).
  - Orders should be displayed correctly.
Comment 2 David Nind 2023-12-11 20:22:15 UTC
Created attachment 159719 [details] [review]
Bug 35351: Adjust basket details template to avoid showing empty page-section

This patch makes a minor change to the markup of the basket details page
so that we don't display an empty div.page-section when there are no
orders.

Note: This patch includes whitespace changes, so please ignore
whitespace when viewing the diff.

To test, apply the patch and go to Acquisitions.

- Search for a vendor and add a basket if necessary.
- View the details of an empty basket.
- Under the "General information" or "Settings" sections there should be
  no empty white box.
- View the details of a basket which has orders (using the "Add to
  basket" process if necessary).
  - Orders should be displayed correctly.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Emily Lamancusa 2024-01-25 18:00:55 UTC
Created attachment 161455 [details] [review]
Bug 35351: Adjust basket details template to avoid showing empty page-section

This patch makes a minor change to the markup of the basket details page
so that we don't display an empty div.page-section when there are no
orders.

Note: This patch includes whitespace changes, so please ignore
whitespace when viewing the diff.

To test, apply the patch and go to Acquisitions.

- Search for a vendor and add a basket if necessary.
- View the details of an empty basket.
- Under the "General information" or "Settings" sections there should be
  no empty white box.
- View the details of a basket which has orders (using the "Add to
  basket" process if necessary).
  - Orders should be displayed correctly.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Comment 4 Emily Lamancusa 2024-01-25 18:07:02 UTC
Looks good, QA script is happy. Passing QA