Bug 35376 - Rephrase: Be careful removing attribute to this processing, the items using it will be impacted as well!
Summary: Rephrase: Be careful removing attribute to this processing, the items using i...
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: I18N/L10N (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Jonathan Druart
QA Contact: Kyle M Hall
URL:
Keywords: Academy
Depends on: 30708
Blocks:
  Show dependency treegraph
 
Reported: 2023-11-21 12:01 UTC by Katrin Fischer
Modified: 2023-12-14 20:51 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.01


Attachments
Bug 35376: Rephrase "be careful..." (1.22 KB, patch)
2023-11-28 10:40 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 35376: Rephrase "be careful..." (1.26 KB, patch)
2023-11-29 10:26 UTC, David Nind
Details | Diff | Splinter Review
Bug 35376: Rephrase "be careful..." (1.32 KB, patch)
2023-12-01 17:28 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2023-11-21 12:01:29 UTC
It feels like this might be missing a word:

Be careful removing attribute to this processing, the items using it will be impacted as well!

koha-tmpl/intranet-tmpl/prog/js/vue/components/Preservation/SettingsProcessingsFormAdd.vue:49
Comment 1 Jonathan Druart 2023-11-21 12:44:37 UTC
Is that better?
"Be careful when removing attributes from this processing: the items using it will be impacted as well!"
Comment 2 Katrin Fischer 2023-11-27 18:02:52 UTC
yes!
Comment 3 Jonathan Druart 2023-11-28 10:40:01 UTC
Created attachment 159285 [details] [review]
Bug 35376: Rephrase "be careful..."
Comment 4 David Nind 2023-11-29 10:26:45 UTC
Created attachment 159325 [details] [review]
Bug 35376: Rephrase "be careful..."

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 Kyle M Hall 2023-12-01 17:28:19 UTC
Created attachment 159469 [details] [review]
Bug 35376: Rephrase "be careful..."

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 6 Katrin Fischer 2023-12-07 11:05:24 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 7 Fridolin Somers 2023-12-07 21:19:52 UTC
Pushed to 23.11.x for 23.11.01
Comment 8 Lucas Gass 2023-12-14 20:51:27 UTC
Not needed int 23.05.x, no backport.