35387 – Capitalization: Labels in preservation module are not capitalized

Bug 35387 - Capitalization: Labels in preservation module are not capitalized

Summary: Capitalization: Labels in preservation module are not capitalized

Status:	CLOSED FIXED

Alias:	None

Product:	Koha
Classification:	Unclassified
Component:	Preservation (show other bugs)
Version:	unspecified
Hardware:	All All

Importance:	P5 - low trivial
Assignee:	Owen Leonard
QA Contact:	Testopia

URL:
Keywords:

Depends on:	30708
Blocks:
	Show dependency tree / graph

Reported:	2023-11-22 20:50 UTC by Tomás Cohen Arazi (tcohen)
Modified:	2024-12-23 08:06 UTC (History)
CC List:	5 users (show)

See Also:
Change sponsored?:	---
Patch complexity:	String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:	This fixes the capitalization of some label names in the Preservation module (name -> Name, and barcode -> Barcode).
Version(s) released in:	24.05.00,23.11.01
Circulation function:

Attachments
Bug 35387: Fix capitalization of 'name' label in preservation module (1.16 KB, patch) 2023-11-22 20:56 UTC, Tomás Cohen Arazi (tcohen)	Details \| Diff \| Splinter Review
Bug 35387: Fix capitalization of 'name' label in preservation module (1.21 KB, patch) 2023-11-22 21:07 UTC, David Nind	Details \| Diff \| Splinter Review
Bug 35387: (follow-up) Capitalize 'barcode' (1.49 KB, patch) 2023-11-23 11:31 UTC, Tomás Cohen Arazi (tcohen)	Details \| Diff \| Splinter Review
Bug 35387: Fix capitalization of 'name' label in preservation module (1.28 KB, patch) 2023-11-23 12:19 UTC, Jonathan Druart	Details \| Diff \| Splinter Review
Bug 35387: (follow-up) Capitalize 'barcode' (1.56 KB, patch) 2023-11-23 12:19 UTC, Jonathan Druart	Details \| Diff \| Splinter Review
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Tomás Cohen Arazi (tcohen) 2023-11-22 20:50:33 UTC

Comment 1 Tomás Cohen Arazi (tcohen) 2023-11-22 20:56:34 UTC

Created attachment 159198 [details] [review]
Bug 35387: Fix capitalization of 'name' label in preservation module

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Comment 2 David Nind 2023-11-22 21:07:35 UTC

Created attachment 159199 [details] [review]
Bug 35387: Fix capitalization of 'name' label in preservation module

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: David Nind <david@davidnind.com>

Comment 3 David Nind 2023-11-22 21:12:12 UTC

Testing notes (using KTD):

1. Enable the preservation module (PreservationModule system preference).
2. Go to: Home > Preservation > Trains > New train
3. Note that the name field label is in lower case (name).
4. Apply the patch.
5. Refresh the page.
6. Note that the name field is now correctly labelled as 'Name'.

Comment 4 David Nind 2023-11-22 21:47:11 UTC

Also needs a 'yarn build' after the patch is applied.

Comment 5 Tomás Cohen Arazi (tcohen) 2023-11-23 11:31:36 UTC

Created attachment 159207 [details] [review]
Bug 35387: (follow-up) Capitalize 'barcode'

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Comment 6 Jonathan Druart 2023-11-23 12:19:53 UTC

Created attachment 159208 [details] [review]
Bug 35387: Fix capitalization of 'name' label in preservation module

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Comment 7 Jonathan Druart 2023-11-23 12:19:56 UTC

Created attachment 159209 [details] [review]
Bug 35387: (follow-up) Capitalize 'barcode'

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Comment 8 Katrin Fischer 2023-12-07 11:05:33 UTC

Pushed for 24.05!

Well done everyone, thank you!

Comment 9 Fridolin Somers 2023-12-07 21:18:24 UTC

Pushed to 23.11.x for 23.11.01

Comment 10 Lucas Gass (lukeg) 2023-12-14 20:48:24 UTC

No preservation module in 23.05.x, no backport.