Bug 35397 - SIP2AddOpacMessagesToScreenMessage syspref description issue
Summary: SIP2AddOpacMessagesToScreenMessage syspref description issue
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low trivial
Assignee: Tomás Cohen Arazi (tcohen)
QA Contact: Emily Lamancusa (emlam)
URL:
Keywords:
: 35448 (view as bug list)
Depends on: 25816
Blocks:
  Show dependency tree / graph
 
Reported: 2023-11-24 13:05 UTC by Tomás Cohen Arazi (tcohen)
Modified: 2024-12-23 08:06 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.04
Circulation function:

Attachments
Bug 35397: Fix SIP2AddOpacMessagesToScreenMessage syspref description (1.37 KB, patch)
2023-11-24 13:11 UTC, Tomás Cohen Arazi (tcohen) 		Details | Diff | Splinter Review
Bug 35397: Fix SIP2AddOpacMessagesToScreenMessage syspref description (1.42 KB, patch)
2023-11-28 14:00 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 35397: Fix SIP2AddOpacMessagesToScreenMessage syspref description (1.49 KB, patch)
2024-01-25 18:45 UTC, Emily Lamancusa (emlam) 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi (tcohen) 2023-11-24 13:05:15 UTC 
There's an extra '- Use' that shouldn't be there.
Comment 1 Tomás Cohen Arazi (tcohen) 2023-11-24 13:11:23 UTC 
Created attachment 159241 [details] [review]
Bug 35397: Fix SIP2AddOpacMessagesToScreenMessage syspref description

The original syspref description contained an extra  '- Use' and reads
weird.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 2 Owen Leonard 2023-11-28 14:00:43 UTC 
Created attachment 159296 [details] [review]
Bug 35397: Fix SIP2AddOpacMessagesToScreenMessage syspref description

The original syspref description contained an extra  '- Use' and reads
weird.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Emily Lamancusa (emlam) 2024-01-25 18:45:18 UTC 
Created attachment 161460 [details] [review]
Bug 35397: Fix SIP2AddOpacMessagesToScreenMessage syspref description

The original syspref description contained an extra  '- Use' and reads
weird.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Comment 4 Emily Lamancusa (emlam) 2024-01-25 18:47:56 UTC 
Good catch - passing QA
Comment 5 Katrin Fischer 2024-03-07 14:03:53 UTC 
Pushed for 24.05!

Well done everyone, thank you!
Comment 6 Fridolin Somers 2024-03-11 09:33:54 UTC 
Pushed to 23.11.x for 23.11.04
Comment 7 Lucas Gass (lukeg) 2024-03-19 15:17:31 UTC 
Doesn't apply clean to 23.05.x, no backport.
Comment 8 David Nind 2024-05-20 21:46:49 UTC 
*** Bug 35448 has been marked as a duplicate of this bug. ***