Bug 35410 - 856 label is inconsistent between detail page and search results in XSLTs
Summary: 856 label is inconsistent between detail page and search results in XSLTs
Status: Pushed to oldoldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Searching (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: David Nind
QA Contact: David Cook
URL:
Keywords: Academy, Sandbox
Depends on:
Blocks:
 
Reported: 2023-11-28 02:52 UTC by David Cook
Modified: 2024-11-15 01:58 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This updates the default staff interface and OPAC XSLT files so that "Online resources" is used as the label in search results for field 856 - Electronic Location and Access, instead of "Online access". This matches the label used in the detail page for a record. It also adjusts the CSS class so OPAC and staff interface both use online_resources.
Version(s) released in:
24.05.00,23.11.01,23.05.07
Circulation function:

Attachments
Bug 35410: Use "Online resources" label in search results (2.76 KB, patch)
2023-12-04 04:17 UTC, David Nind 		Details | Diff | Splinter Review
Bug 35410: Use "Online resources" label in search results (2.76 KB, patch)
2023-12-04 04:18 UTC, David Nind 		Details | Diff | Splinter Review
Bug 35410: Use "Online resources" label in search results (2.81 KB, patch)
2023-12-04 19:54 UTC, Lucas Gass (lukeg) 		Details | Diff | Splinter Review
Bug 35410: Use "Online resources" label in search results (2.86 KB, patch)
2023-12-04 22:49 UTC, David Cook 		Details | Diff | Splinter Review
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Cook 2023-11-28 02:52:47 UTC 
In the search results it says "Online access" and on the detail page it says "Online resources".

Same pattern for both the staff interface and the OPAC.
Comment 1 David Cook 2023-11-28 02:53:47 UTC 
I think both "Online access" and "Online resources" are equally descriptive, so how do we pick one?
Comment 2 Katrin Fischer 2023-11-28 11:55:06 UTC 
For me 'online resources' is the broader term which I think would be a better fit since currently we show all links together, not differentiating between full text and other links (covers, TOCs, reviews, etc.).
Comment 3 David Cook 2023-11-28 23:11:16 UTC 
(In reply to Katrin Fischer from comment #2)
> For me 'online resources' is the broader term which I think would be a
> better fit since currently we show all links together, not differentiating
> between full text and other links (covers, TOCs, reviews, etc.).

Sounds good to me!
Comment 4 David Nind 2023-12-04 04:17:46 UTC 
Created attachment 159513 [details] [review]
Bug 35410: Use "Online resources" label in search results

Update the staff interface and OPAC XSLT files to use
"Online resources" as the label in search results, instead of
"Online access". This matches the label used in the detail page
for a record.

Test plan:
1. Search for perl in the staff interface and OPAC (or add to
   an existing record a URL to 856$u with 4 for the first
   indicator).
2. For any search result that displays the "Online access" label,
   view the detail page for the record.
3. Note that the detail page uses the label "Online resources".
4. Apply the patch and restart_all.
5. Repeat steps 1 and 2.
6. Note that the search result pages now show "Online resources" for
   the label, matching the detail page.

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 David Nind 2023-12-04 04:18:26 UTC 
Created attachment 159514 [details] [review]
Bug 35410: Use "Online resources" label in search results

Update the staff interface and OPAC XSLT files to use
"Online resources" as the label in search results, instead of
"Online access". This matches the label used in the detail page
for a record.

Test plan:
1. Search for perl in the staff interface and OPAC (or add to
   an existing record a URL to 856$u with 4 for the first
   indicator).
2. For any search result that displays the "Online access" label,
   view the detail page for the record.
3. Note that the detail page uses the label "Online resources".
4. Apply the patch and restart_all.
5. Repeat steps 1 and 2.
6. Note that the search result pages now show "Online resources" for
   the label, matching the detail page.

Signed-off-by: David Nind <david@davidnind.com>
Comment 6 David Cook 2023-12-04 04:27:50 UTC 
Legend! I was just thinking how I needed to get around to this, so thanks for taking care of it :).
Comment 7 David Cook 2023-12-04 04:28:32 UTC 
I might let someone else sign off so that I can QA it.
Comment 8 David Nind 2023-12-04 04:52:35 UTC 
From what I can tell, no update for UNIMARC is required.
Comment 9 Lucas Gass (lukeg) 2023-12-04 19:54:34 UTC 
Created attachment 159562 [details] [review]
Bug 35410: Use "Online resources" label in search results

Update the staff interface and OPAC XSLT files to use
"Online resources" as the label in search results, instead of
"Online access". This matches the label used in the detail page
for a record.

Test plan:
1. Search for perl in the staff interface and OPAC (or add to
   an existing record a URL to 856$u with 4 for the first
   indicator).
2. For any search result that displays the "Online access" label,
   view the detail page for the record.
3. Note that the detail page uses the label "Online resources".
4. Apply the patch and restart_all.
5. Repeat steps 1 and 2.
6. Note that the search result pages now show "Online resources" for
   the label, matching the detail page.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 10 David Cook 2023-12-04 22:49:07 UTC 
Created attachment 159565 [details] [review]
Bug 35410: Use "Online resources" label in search results

Update the staff interface and OPAC XSLT files to use
"Online resources" as the label in search results, instead of
"Online access". This matches the label used in the detail page
for a record.

Test plan:
1. Search for perl in the staff interface and OPAC (or add to
   an existing record a URL to 856$u with 4 for the first
   indicator).
2. For any search result that displays the "Online access" label,
   view the detail page for the record.
3. Note that the detail page uses the label "Online resources".
4. Apply the patch and restart_all.
5. Repeat steps 1 and 2.
6. Note that the search result pages now show "Online resources" for
   the label, matching the detail page.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: David Cook <dcook@prosentient.com.au>
Comment 11 David Nind 2023-12-05 05:27:02 UTC 
Thanks Lucas for the sign-off and David for the QA!

David
Comment 12 Katrin Fischer 2023-12-07 11:05:39 UTC 
Pushed for 24.05!

Well done everyone, thank you!
Comment 13 Katrin Fischer 2023-12-07 11:09:09 UTC 
Note: I like the consistency of the change to the class, but it could have some side effects for existing CSS. I decided to push, because the change is in the staff interface, not in the OPAC.
Comment 14 Fridolin Somers 2023-12-07 21:24:24 UTC 
Pushed to 23.11.x for 23.11.01
Comment 15 David Cook 2023-12-08 03:43:42 UTC 
(In reply to Katrin Fischer from comment #13)
> Note: I like the consistency of the change to the class, but it could have
> some side effects for existing CSS. I decided to push, because the change is
> in the staff interface, not in the OPAC.

I was thinking the same thing. Initially, I thought we should've kept the existing class and added the new one, but then I figured since it's the staff interface people can just update on upgrade as needed.
Comment 16 Lucas Gass (lukeg) 2023-12-14 21:00:26 UTC 
Backported to 23.05.x for upcoming 23.05.07