Bug 35412 - Capitalization: Toggle Dropdown
Summary: Capitalization: Toggle Dropdown
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2023-11-28 11:37 UTC by Katrin Fischer
Modified: 2024-12-23 08:06 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.01
Circulation function:

Attachments
Bug 35412: Fix incorrect capitalization: Toggle Dropdown (1.49 KB, patch)
2023-11-28 14:10 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 35412: Fix incorrect capitalization: Toggle Dropdown (1.53 KB, patch)
2023-11-29 09:55 UTC, David Nind 		Details | Diff | Splinter Review
Bug 35412: Fix incorrect capitalization: Toggle Dropdown (1.59 KB, patch)
2023-12-07 04:27 UTC, Victor Grousset/tuxayo 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2023-11-28 11:37:06 UTC 
koha-tmpl/intranet-tmpl/prog/en/includes/last-borrower.inc:9
Comment 1 Owen Leonard 2023-11-28 14:10:08 UTC 
Created attachment 159297 [details] [review]
Bug 35412: Fix incorrect capitalization: Toggle Dropdown

This patch corrects incorrect capitalization in the last-borrower
include file. The string his hidden except to screen readers, so visual
confirmation isn't straightforward. Viewing the diff should be enough to
confirm this single character change.
Comment 2 David Nind 2023-11-29 09:55:56 UTC 
Created attachment 159321 [details] [review]
Bug 35412: Fix incorrect capitalization: Toggle Dropdown

This patch corrects incorrect capitalization in the last-borrower
include file. The string his hidden except to screen readers, so visual
confirmation isn't straightforward. Viewing the diff should be enough to
confirm this single character change.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Victor Grousset/tuxayo 2023-12-07 04:27:52 UTC 
Created attachment 159628 [details] [review]
Bug 35412: Fix incorrect capitalization: Toggle Dropdown

This patch corrects incorrect capitalization in the last-borrower
include file. The string his hidden except to screen readers, so visual
confirmation isn't straightforward. Viewing the diff should be enough to
confirm this single character change.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Comment 4 Victor Grousset/tuxayo 2023-12-07 04:28:31 UTC 
Trivial change, makes sense, QA script happy, code looks good, passing QA :)
Comment 5 Katrin Fischer 2023-12-07 11:05:42 UTC 
Pushed for 24.05!

Well done everyone, thank you!
Comment 6 Fridolin Somers 2023-12-07 21:20:28 UTC 
Pushed to 23.11.x for 23.11.01
Comment 7 Lucas Gass (lukeg) 2023-12-14 20:53:40 UTC 
Not needed in 23.05.x, no backport.