Bug 35467 - NewsLog should be renamed
Summary: NewsLog should be renamed
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Andrew Fuerste-Henry
QA Contact: Pedro Amorim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-12-01 16:33 UTC by Lucas Gass (lukeg)
Modified: 2025-08-13 19:41 UTC (History)
2 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.11.00
Circulation function:


Attachments
Bug 35467: Rename NewsLog system preference to AdditionalContent (7.64 KB, patch)
2025-08-05 13:41 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 35467: atomicupdate to change NewsLog to AdditionalContentLog (1.31 KB, patch)
2025-08-05 13:42 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 35467: Rename NewsLog system preference to AdditionalContent (7.72 KB, patch)
2025-08-05 14:22 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 35467: atomicupdate to change NewsLog to AdditionalContentLog (1.36 KB, patch)
2025-08-05 14:22 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 35467: atomicupdate to rename NewsLog to AdditionalContentLog (682 bytes, patch)
2025-08-05 15:16 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 35467L (QA followup): Spelling correction in syspref (1.12 KB, patch)
2025-08-05 15:17 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 35467: Rename NewsLog system preference to AdditionalContent (7.77 KB, patch)
2025-08-05 15:23 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 35467: atomicupdate to change NewsLog to AdditionalContentLog (1.42 KB, patch)
2025-08-05 15:23 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 35467: atomicupdate to rename NewsLog to AdditionalContentLog (742 bytes, patch)
2025-08-05 15:24 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 35467: (QA follow-up): Spelling correction in syspref (1.21 KB, patch)
2025-08-05 15:24 UTC, Pedro Amorim
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass (lukeg) 2023-12-01 16:33:21 UTC
The system preference NewsLog should indicate that it logs changes from news, html customizations, or pages. 

It should be renamed accordingly. AdditionalContentsLog ?
Comment 1 Andrew Fuerste-Henry 2025-08-05 13:41:58 UTC
Created attachment 185119 [details] [review]
Bug 35467: Rename NewsLog system preference to AdditionalContent

To test:
1 - confirm whether or not NewsLog is enabled on your system
2 - apply patch, updatedatabase, restart_all
3 - search system preferences, confirm you now have AdditionalContentLog rather than NewsLog and that the new description is accurate
4 - confitm AdditionalContentLog shows the value you previously had for NewsLog
5 - go to Tools > Log Viewer
6 - confirm the checkbox here is labeled "Additional Content", that it correctly reflects the syspref value, and that it links to the syspref
7 - with AdditionalContentLog enabled, created/edit/delete news, HTML customizations, and pages. confirm they log
8 - with AdditionalContentLog disabled, created/edit/delete news, HTML customizations, and pages. confirm they don't log
Comment 2 Andrew Fuerste-Henry 2025-08-05 13:42:01 UTC
Created attachment 185120 [details] [review]
Bug 35467: atomicupdate to change NewsLog to AdditionalContentLog
Comment 3 Owen Leonard 2025-08-05 14:22:32 UTC
Created attachment 185122 [details] [review]
Bug 35467: Rename NewsLog system preference to AdditionalContent

To test:
1 - confirm whether or not NewsLog is enabled on your system
2 - apply patch, updatedatabase, restart_all
3 - search system preferences, confirm you now have
    AdditionalContentLog rather than NewsLog and that the new
    description is accurate
4 - confitm AdditionalContentLog shows the value you previously had for
    NewsLog
5 - go to Tools > Log Viewer
6 - confirm the checkbox here is labeled "Additional Content", that it
    correctly reflects the syspref value, and that it links to the
    syspref
7 - with AdditionalContentLog enabled, created/edit/delete news, HTML
    customizations, and pages. confirm they log
8 - with AdditionalContentLog disabled, created/edit/delete news, HTML
    customizations, and pages. confirm they don't log

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 4 Owen Leonard 2025-08-05 14:22:34 UTC
Created attachment 185123 [details] [review]
Bug 35467: atomicupdate to change NewsLog to AdditionalContentLog

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 5 Pedro Amorim 2025-08-05 14:57:27 UTC
1) QA script not happy:
[FAIL] installer/data/mysql/atomicupdate/bug_35467_AdditionalContentLog.pl
   FAIL   file_permissions
                File must have the exec flag

2) Typo here:
 changes to HTML customizations, news entires,
 news entries*

3) Minor observation: Should we call it AdditionalContentsLog (plural)?
Comment 6 Andrew Fuerste-Henry 2025-08-05 15:07:39 UTC
(In reply to Pedro Amorim from comment #5)
> 3) Minor observation: Should we call it AdditionalContentsLog (plural)?

I wondered about this. In the staff interface, if you go to any of these tools the page says "Additional content: Pages" or "Additional content: News." So I followed that, but don't have strong feelings.
Comment 7 Andrew Fuerste-Henry 2025-08-05 15:16:59 UTC
Created attachment 185127 [details] [review]
Bug 35467: atomicupdate to rename NewsLog to AdditionalContentLog

Now executable!
Comment 8 Andrew Fuerste-Henry 2025-08-05 15:17:02 UTC
Created attachment 185128 [details] [review]
Bug 35467L (QA followup): Spelling correction in syspref
Comment 9 Pedro Amorim 2025-08-05 15:23:56 UTC
Created attachment 185129 [details] [review]
Bug 35467: Rename NewsLog system preference to AdditionalContent

To test:
1 - confirm whether or not NewsLog is enabled on your system
2 - apply patch, updatedatabase, restart_all
3 - search system preferences, confirm you now have
    AdditionalContentLog rather than NewsLog and that the new
    description is accurate
4 - confitm AdditionalContentLog shows the value you previously had for
    NewsLog
5 - go to Tools > Log Viewer
6 - confirm the checkbox here is labeled "Additional Content", that it
    correctly reflects the syspref value, and that it links to the
    syspref
7 - with AdditionalContentLog enabled, created/edit/delete news, HTML
    customizations, and pages. confirm they log
8 - with AdditionalContentLog disabled, created/edit/delete news, HTML
    customizations, and pages. confirm they don't log

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk>
Comment 10 Pedro Amorim 2025-08-05 15:23:58 UTC
Created attachment 185130 [details] [review]
Bug 35467: atomicupdate to change NewsLog to AdditionalContentLog

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk>
Comment 11 Pedro Amorim 2025-08-05 15:24:00 UTC
Created attachment 185131 [details] [review]
Bug 35467: atomicupdate to rename NewsLog to AdditionalContentLog

Now executable!

Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk>
Comment 12 Pedro Amorim 2025-08-05 15:24:03 UTC
Created attachment 185132 [details] [review]
Bug 35467: (QA follow-up): Spelling correction in syspref

PA amendded: Commit title

Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk>
Comment 13 Lucas Gass (lukeg) 2025-08-13 19:41:17 UTC
Nice work everyone!

Pushed to main for 25.11