Bug 35576 - Make hq-callnumber column easier to customize when viewing the holds queue report
Summary: Make hq-callnumber column easier to customize when viewing the holds queue re...
Status: Passed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Lucas Gass
QA Contact: Emily Lamancusa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-12-14 22:37 UTC by Lucas Gass
Modified: 2024-02-23 07:06 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 35576: Add classes to hq-callnumber column in holds report (2.47 KB, patch)
2023-12-14 22:43 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 35576: Add classes to hq-callnumber column in holds report (2.52 KB, patch)
2023-12-17 02:14 UTC, David Nind
Details | Diff | Splinter Review
Bug 35576: Add classes to hq-callnumber column in holds report (2.59 KB, patch)
2024-01-25 18:58 UTC, Emily Lamancusa
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass 2023-12-14 22:37:48 UTC
When viewing the holds queue report there is a column for itemcallnumber (.hq-callnumber). This column contains both item.itemcallnumber and item.location data. 

It would be easier to customize each piece of data separately if they were each wrapped in a span with a class name.
Comment 1 Lucas Gass 2023-12-14 22:43:13 UTC
Created attachment 159855 [details] [review]
Bug 35576: Add classes to hq-callnumber column in holds report

To test:
1. APPLY PATCH
2. Make sure you have item.itemcallnumber data.
3. Have some holds and build the holds queue: perl /kohadevbox/koha/misc/cronjobs/holds/build_holds_queue.pl
4. To make testing easier add the following to IntranetUserCSS:
    .hq-callnumber .location { background: lightblue; }
    .hq-callnumber .itemcallnumber { background: lightgoldenrodyellow; }
5. Run the holds queue and notice that the data in the 'Call number' column has a lightblue (location) and lightgoldenrodyellow (call number) background.
Comment 2 David Nind 2023-12-17 02:14:17 UTC
Created attachment 159930 [details] [review]
Bug 35576: Add classes to hq-callnumber column in holds report

To test:
1. APPLY PATCH
2. Make sure you have item.itemcallnumber data.
3. Have some holds and build the holds queue: perl /kohadevbox/koha/misc/cronjobs/holds/build_holds_queue.pl
4. To make testing easier add the following to IntranetUserCSS:
    .hq-callnumber .location { background: lightblue; }
    .hq-callnumber .itemcallnumber { background: lightgoldenrodyellow; }
5. Run the holds queue and notice that the data in the 'Call number' column has a lightblue (location) and lightgoldenrodyellow (call number) background.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Emily Lamancusa 2024-01-25 18:58:16 UTC
Created attachment 161461 [details] [review]
Bug 35576: Add classes to hq-callnumber column in holds report

To test:
1. APPLY PATCH
2. Make sure you have item.itemcallnumber data.
3. Have some holds and build the holds queue: perl /kohadevbox/koha/misc/cronjobs/holds/build_holds_queue.pl
4. To make testing easier add the following to IntranetUserCSS:
    .hq-callnumber .location { background: lightblue; }
    .hq-callnumber .itemcallnumber { background: lightgoldenrodyellow; }
5. Run the holds queue and notice that the data in the 'Call number' column has a lightblue (location) and lightgoldenrodyellow (call number) background.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Comment 4 Emily Lamancusa 2024-01-25 18:59:20 UTC
Nice quality-of-life improvement! Looks good, QA script is happy. Passing QA