Bug 35643 - Upgrade HC Sticky library from v2.2.3 to v2.2.7
Summary: Upgrade HC Sticky library from v2.2.3 to v2.2.7
Status: Passed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 35584 21751
Blocks:
  Show dependency treegraph
 
Reported: 2023-12-22 15:42 UTC by Owen Leonard
Modified: 2024-02-07 18:44 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 35643: Upgrade HC Sticky library from v2.2.3 to v2.2.7 (61.84 KB, patch)
2023-12-22 16:11 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 35643: Upgrade HC Sticky library from v2.2.3 to v2.2.7 (61.90 KB, patch)
2023-12-26 15:47 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 35643: Upgrade HC Sticky library from v2.2.3 to v2.2.7 (62.02 KB, patch)
2024-01-04 12:59 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 35643: Upgrade HC Sticky library from v2.2.3 to v2.2.7 (61.92 KB, patch)
2024-02-07 18:44 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-12-22 15:42:10 UTC
The copy of HC Sticky we use is from 2018. We can upgrade it to a version which was released in 2021.
Comment 1 Owen Leonard 2023-12-22 16:11:12 UTC
Created attachment 160254 [details] [review]
Bug 35643: Upgrade HC Sticky library from v2.2.3 to v2.2.7

This patch upgrades the HC Sticky library in the OPAC and staff
interface to the latest version, 2.2.7. The file is moved to its own
directory for consistency's sake.

To test, apply the patch and clear your browser cache if ncessary.

Test pages in the OPAC and staff interface which use the "sticky"
heading feature. As you scroll down the header should "stick" to the top
of the viewport. For example:

- Administration -> System preferences
- Catalog -> Search results
- Cataloging -> Basic MARC editor
- Patrons -> Add or edit patron
- Lists -> List contents

In the OPAC:

- Catalog search results
- Lists -> List contents
Comment 2 Lucas Gass 2023-12-26 15:47:47 UTC
Created attachment 160299 [details] [review]
Bug 35643: Upgrade HC Sticky library from v2.2.3 to v2.2.7

This patch upgrades the HC Sticky library in the OPAC and staff
interface to the latest version, 2.2.7. The file is moved to its own
directory for consistency's sake.

To test, apply the patch and clear your browser cache if ncessary.

Test pages in the OPAC and staff interface which use the "sticky"
heading feature. As you scroll down the header should "stick" to the top
of the viewport. For example:

- Administration -> System preferences
- Catalog -> Search results
- Cataloging -> Basic MARC editor
- Patrons -> Add or edit patron
- Lists -> List contents

In the OPAC:

- Catalog search results
- Lists -> List contents

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 3 Jonathan Druart 2024-01-04 12:48:10 UTC
Noting, but not coming from this patch:

https://snipboard.io/w431b6.jpg

There is a gap between the 2 headers (OPAC)
Comment 4 Jonathan Druart 2024-01-04 12:48:44 UTC
Coming from the rule margin-top: 3px on .selections-toolbar
Comment 5 Jonathan Druart 2024-01-04 12:59:19 UTC
Created attachment 160529 [details] [review]
Bug 35643: Upgrade HC Sticky library from v2.2.3 to v2.2.7

This patch upgrades the HC Sticky library in the OPAC and staff
interface to the latest version, 2.2.7. The file is moved to its own
directory for consistency's sake.

To test, apply the patch and clear your browser cache if ncessary.

Test pages in the OPAC and staff interface which use the "sticky"
heading feature. As you scroll down the header should "stick" to the top
of the viewport. For example:

- Administration -> System preferences
- Catalog -> Search results
- Cataloging -> Basic MARC editor
- Patrons -> Add or edit patron
- Lists -> List contents

In the OPAC:

- Catalog search results
- Lists -> List contents

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 6 Owen Leonard 2024-02-07 18:44:55 UTC
Created attachment 161847 [details] [review]
Bug 35643: Upgrade HC Sticky library from v2.2.3 to v2.2.7

This patch upgrades the HC Sticky library in the OPAC and staff
interface to the latest version, 2.2.7. The file is moved to its own
directory for consistency's sake.

To test, apply the patch and clear your browser cache if ncessary.

Test pages in the OPAC and staff interface which use the "sticky"
heading feature. As you scroll down the header should "stick" to the top
of the viewport. For example:

- Administration -> System preferences
- Catalog -> Search results
- Cataloging -> Basic MARC editor
- Patrons -> Add or edit patron
- Lists -> List contents

In the OPAC:

- Catalog search results
- Lists -> List contents

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>