Bug 35709 - [23.11] Renew selected items button is inactive when overdue items are preselected automatically
Summary: [23.11] Renew selected items button is inactive when overdue items are presel...
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: 23.11
Hardware: All All
: P5 - low major
Assignee: Baptiste Wojtkowski (bwoj)
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords: rel_23_11_candidate
Depends on:
Blocks:
 
Reported: 2024-01-05 13:30 UTC by Anneli Österman
Modified: 2025-02-03 16:13 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.11
Circulation function:


Attachments
Renew selected items button is inactive (41.09 KB, image/png)
2024-01-05 13:48 UTC, Anneli Österman
Details
Bug 35709: 23.11 version of bug 36060 (4.66 KB, patch)
2024-12-04 12:36 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 35709: 23.11 version of bug 36060 (4.72 KB, patch)
2024-12-04 13:13 UTC, Baptiste Wojtkowski (bwoj)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Anneli Österman 2024-01-05 13:30:35 UTC
Renew or checkin selected items button were seperated to two buttons (wich is great). When you go to patron's checkouts and there are overdue items, they are selected automatically for renewal (as previously). But now the Renew selected items button is inactive and you have to click one of the overdue items on the Renew colum to activate the button. And click it again to renew that one too.

This happens in both cgi-bin/koha/members/moremember.pl and cgi-bin/koha/circ/circulation.pl pages.
Comment 1 Anneli Österman 2024-01-05 13:48:54 UTC
Created attachment 160574 [details]
Renew selected items button is inactive

Screenshot
Comment 2 Baptiste Wojtkowski (bwoj) 2024-09-27 08:38:38 UTC

*** This bug has been marked as a duplicate of bug 36060 ***
Comment 3 Martin Renvoize (ashimema) 2024-12-03 10:34:19 UTC
Re-opening as this is still an issue in 23.11.x series and the fix in the duplicate bug only applies to 24.05.x onwards
Comment 4 Martin Renvoize (ashimema) 2024-12-04 12:36:18 UTC
Created attachment 175172 [details] [review]
Bug 35709: 23.11 version of bug 36060

This just replicates the logic of bug 36060 for the 23.11.x branch.
Follow the same test plan as for that bug.
Comment 5 Anneli Österman 2024-12-04 13:08:04 UTC
I tried to apply the patch to Bywater's sandbox made in 23.11.x branch but I get this message:

Bug 35709 - Renew selected items button is inactive when overdue items are preselected automatically

175172 - Bug 35709: 23.11 version of bug 36060

Apply? [(y)es, (n)o, (i)nteractive] Applying: Bug 35709: 23.11 version of bug 36060
Using index info to reconstruct a base tree...
M	koha-tmpl/intranet-tmpl/prog/js/checkouts.js
error: insufficient permission for adding an object to repository database .git/objects
error: could not write tree
Patch failed at 0001 Bug 35709: 23.11 version of bug 36060
[33mhint: Use 'git am --show-current-patch=diff' to see the failed patch[m
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-35709-2311-version-of-bug-36060-kb7_vu0y.patch

Is it possible to test this on a sandbox?
Comment 6 Baptiste Wojtkowski (bwoj) 2024-12-04 13:13:52 UTC
Created attachment 175174 [details] [review]
Bug 35709: 23.11 version of bug 36060

This just replicates the logic of bug 36060 for the 23.11.x branch.
Follow the same test plan as for that bug.

Signed-off-by: Baptiste <baptiste.wojtkowski@biblibre.com>
Comment 7 Fridolin Somers 2024-12-23 11:21:41 UTC
Pushed to 23.11.x for 23.11.11
Comment 8 Jesse Maseto 2025-02-03 16:13:29 UTC
Not pushed to LTS. Marked Resolved.

If you feel this should be in LTS please reply with your reason.