The table at circ/reserveratios.pl currently has an id of "holdst". The table settings page says that table id should be "holds-ratios". "holdst" is the id for the holds queue table at circ/view_holdsqueue.pl.
Created attachment 161096 [details] [review] Bug 35820: Fix table id on hold ratios page This patch corrects the ID on the table showing holds on the holds ratios page so that it matches the DataTables initialization and configuration. I'm not aware of any bug with the functionality, but consistency is good. The patch also wraps the table in a "page-section" div, an update which includes indentation changes. To test, apply the patch and if necessary, place multiple holds on a title so that the hold ratios page will display results. - Go to Circulation -> Hold ratios. - The table of hold ratios should look correct. - Click the "Configure" button at the top of the table. - On the table settings page, change the default visibility of some columns. - Return to the hold ratios page to confirm that the correct columns are hidden by default.
Created attachment 161102 [details] [review] Bug 35820: Fix table id on hold ratios page This patch corrects the ID on the table showing holds on the holds ratios page so that it matches the DataTables initialization and configuration. I'm not aware of any bug with the functionality, but consistency is good. The patch also wraps the table in a "page-section" div, an update which includes indentation changes. To test, apply the patch and if necessary, place multiple holds on a title so that the hold ratios page will display results. - Go to Circulation -> Hold ratios. - The table of hold ratios should look correct. - Click the "Configure" button at the top of the table. - On the table settings page, change the default visibility of some columns. - Return to the hold ratios page to confirm that the correct columns are hidden by default. Signed-off-by: David Nind <david@davidnind.com>
Testing notes using KTD: 1. Place four holds on a record. 2. To get the report to display I needed to: 2.1 Edit /etc/koha/sites/kohadev/koha-conf.xml 2.2 Change strict mode to 0: <strict_sql_modes>0</strict_sql_modes> 2.3 Restart everything 2.4 Otherwise, I get the group by error trace: CGI::Compile::ROOT::kohadevbox_koha_circ_reserveratios_2epl::reserveratios_2epl(): DBI Exception: DBD::mysql::st execute failed: 'koha_kohadev.reserves.reservedate' isn't in GROUP BY at /usr/share/perl5/CGI/Emulate/PSGI.pm line 30 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 Additional things noted - both before and after the patch: 1. Row alignment - these columns are in the center, whereas all the other columns are aligned to the top of the row: - Holds - Items - Items needed 2. The item type column is labelled 'Itype', should be labelled as 'Item type'.
Created attachment 161206 [details] [review] Bug 35820: Fix table id on hold ratios page This patch corrects the ID on the table showing holds on the holds ratios page so that it matches the DataTables initialization and configuration. I'm not aware of any bug with the functionality, but consistency is good. The patch also wraps the table in a "page-section" div, an update which includes indentation changes. To test, apply the patch and if necessary, place multiple holds on a title so that the hold ratios page will display results. - Go to Circulation -> Hold ratios. - The table of hold ratios should look correct. - Click the "Configure" button at the top of the table. - On the table settings page, change the default visibility of some columns. - Return to the hold ratios page to confirm that the correct columns are hidden by default. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed for 24.05! Well done everyone, thank you!
Pushed to 23.11.x for 23.11.03
Doesn't apply cleanly for 23.05.x, no backport