Bug 35838 - Use template wrapper for tabs: Curbside pickups administration
Summary: Use template wrapper for tabs: Curbside pickups administration
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Owen Leonard
QA Contact: Jonathan Druart
URL:
Keywords:
: 37835 (view as bug list)
Depends on: 32571
Blocks: 37835
  Show dependency tree / graph
 
Reported: 2024-01-18 16:20 UTC by Owen Leonard
Modified: 2024-11-15 17:44 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This enhancement makes structural changes to the way the curbside pickups administration page is generated for more consistency and ease of upgrade to new Bootstrap versions.
Version(s) released in:
24.11.00
Circulation function:

Attachments
Bug 35838: Use template wrapper for tabs: Curbside pickups administration (3.46 KB, patch)
2024-01-18 16:49 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 35838: Use template wrapper for tabs: Curbside pickups administration (3.61 KB, patch)
2024-01-22 13:36 UTC, Biblibre Sandboxes 		Details | Diff | Splinter Review
Bug 35838: Use template wrapper for tabs: Curbside pickups administration (3.48 KB, patch)
2024-04-22 11:14 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 35838: Use template wrapper for tabs: Curbside pickups administration (3.56 KB, patch)
2024-08-15 09:07 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 35838: Use template wrapper for tabs: Curbside pickups administration (3.56 KB, patch)
2024-08-23 17:27 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 35838: Fix addition of new slots (1.42 KB, patch)
2024-09-04 12:51 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2024-01-18 16:20:44 UTC 
Continuing the work of Bug 32571, I would like to update the curbside pickups page in the staff client to use the new WRAPPER for tabs
Comment 1 Owen Leonard 2024-01-18 16:49:41 UTC Comment hidden (obsolete)
Comment 2 Loïc 2024-01-22 13:36:03 UTC 
It works
Comment 3 Biblibre Sandboxes 2024-01-22 13:36:26 UTC Comment hidden (obsolete)
Comment 4 Owen Leonard 2024-04-22 11:14:54 UTC Comment hidden (obsolete)
Comment 5 Jonathan Druart 2024-08-15 09:07:46 UTC Comment hidden (obsolete)
Comment 6 Owen Leonard 2024-08-23 17:27:15 UTC 
Created attachment 170653 [details] [review]
Bug 35838: Use template wrapper for tabs: Curbside pickups administration

This patch updates the curbside pickups administration template so that
it uses the new WRAPPER directive to build tabbed navigation.

To test, apply the patch and enable curbside pickups if necessary:
Administration -> System preferences -> CurbsidePickup.

- Go to Administration -> Curbside pickups.
- Confirm that the tabs look correct and behave as expected.

Signed-off-by: Loïc Vassaux--Artur <loic.vassaux-artur@outlook.fr>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 7 Katrin Fischer 2024-08-26 15:43:36 UTC 
Pushed for 24.11!

Well done everyone, thank you!
Comment 8 Jonathan Druart 2024-09-04 12:51:15 UTC 
Created attachment 171022 [details] [review]
Bug 35838: Fix addition of new slots

The "Add" button didn't add new slots.
Comment 9 Jonathan Druart 2024-09-05 07:37:42 UTC 
*** Bug 37835 has been marked as a duplicate of this bug. ***
Comment 10 Katrin Fischer 2024-09-05 07:50:53 UTC 
Pushed follow-up to main.
Comment 11 Owen Leonard 2024-09-11 14:57:52 UTC 
Does this still need additional_work_needed?
Comment 12 Jonathan Druart 2024-09-12 06:54:34 UTC 
(In reply to Owen Leonard from comment #11)
> Does this still need additional_work_needed?

Nope, removed.