Bug 35936 - Cannot save existing report with incorrect AV category
Summary: Cannot save existing report with incorrect AV category
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: Reports (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low minor
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 33966
Blocks:
  Show dependency tree / graph
 
Reported: 2024-01-30 09:04 UTC by Jonathan Druart
Modified: 2024-02-01 16:23 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.03
Circulation function:

Attachments
Bug 35936: Fix saving existing report with incorrect AV category (1.91 KB, patch)
2024-01-30 09:06 UTC, Jonathan Druart 		Details | Diff | Splinter Review
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2024-01-30 09:04:41 UTC 
When an existing report is saved and an incorrect AV category is selected, the UI is asking "do you want to save anyway", but the "Update SQL" button leads to a blank page and the report is not saved.
Comment 1 Jonathan Druart 2024-01-30 09:06:17 UTC 
Created attachment 161626 [details] [review]
Bug 35936: Fix saving existing report with incorrect AV category

When an existing report is saved and an incorrect AV category is selected,
the UI is asking "do you want to save anyway", but the "Update SQL" button
leads to a blank page and the report is not saved.

On bug 33966 the value is been adjust to 'update_sql' but this incorrect
was left.

To test you need to use the browser inspector to adjust the value of the
selected option.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 2 Jonathan Druart 2024-01-30 09:06:34 UTC 
Trivial, skipping SO and QA.
Comment 4 Katrin Fischer 2024-01-30 16:44:38 UTC 
Sorry, wrong bug!
Comment 5 Katrin Fischer 2024-01-30 16:50:19 UTC 
Pushed for 24.05!

Well done everyone, thank you!
Comment 6 Fridolin Somers 2024-02-01 16:23:44 UTC 
Pushed to 23.11.x for 23.11.03