Bug 36072 - Can request articles even if ArticleRequests is off
Summary: Can request articles even if ArticleRequests is off
Status: Pushed to oldoldoldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Marcel de Rooy
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords:
Depends on: 14610
Blocks:
  Show dependency tree / graph
 
Reported: 2024-02-12 15:36 UTC by Jonathan Druart
Modified: 2024-07-25 11:11 UTC (History)
8 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.03,23.05.09,22.11.15,22.05.19
Circulation function:

Attachments
Bug 36072: opac-request-article should check syspref (1.04 KB, patch)
2024-02-13 12:38 UTC, Marcel de Rooy 		Details | Diff | Splinter Review
Bug 36072: opac-request-article should check syspref (1.07 KB, patch)
2024-02-13 16:35 UTC, Martin Renvoize (ashimema) 		Details | Diff | Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2024-02-12 15:36:54 UTC 
opac/opac-request-article.pl is not testing the syspref.
Comment 1 Marcel de Rooy 2024-02-13 12:38:25 UTC 
Created attachment 162106 [details] [review]
Bug 36072: opac-request-article should check syspref

Note: This is handled now just like opac-reserve.

Test plan:
Disable ArticleRequests and hit the page.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 2 Marcel de Rooy 2024-02-13 12:40:27 UTC 
I am not sure that this should be a security report. Is this about DDOS attack on the page, filling the database or so?
Comment 3 Marcel de Rooy 2024-02-13 12:40:45 UTC 
Trivial patch, self SO
Comment 4 Martin Renvoize (ashimema) 2024-02-13 16:35:29 UTC 
Created attachment 162119 [details] [review]
Bug 36072: opac-request-article should check syspref

Note: This is handled now just like opac-reserve.

Test plan:
Disable ArticleRequests and hit the page.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Martin Renvoize (ashimema) 2024-02-13 16:36:00 UTC 
Trivlal fix, works, and passes QA scripts.

Passing QA
Comment 6 Martin Renvoize (ashimema) 2024-02-15 09:46:35 UTC 
Pushed to master for 24.05.00