Bug 36088 - Remove useless code form opac-account-pay.pl
Summary: Remove useless code form opac-account-pay.pl
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Kyle M Hall
QA Contact: Testopia
URL:
Keywords:
Depends on: 23215
Blocks:
  Show dependency treegraph
 
Reported: 2024-02-13 20:04 UTC by Kyle M Hall
Modified: 2024-03-19 15:14 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.04,23.05.10


Attachments
Bug 36088 - Remove useless code form opac-account-pay.pl (1.21 KB, patch)
2024-02-13 20:07 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 36088 - Remove useless code form opac-account-pay.pl (1.26 KB, patch)
2024-02-16 22:46 UTC, David Nind
Details | Diff | Splinter Review
Bug 36088 - Remove useless code form opac-account-pay.pl (1.32 KB, patch)
2024-02-20 09:55 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 36088: Remove useless code form opac-account-pay.pl (1.35 KB, patch)
2024-02-20 10:08 UTC, Pedro Amorim
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2024-02-13 20:04:34 UTC
The script opac-account-pay.pl sums the selected accountlines, formats the amount, pulls the currently active currency, and does nothing with any of this data.
Comment 1 Kyle M Hall 2024-02-13 20:07:34 UTC
Created attachment 162128 [details] [review]
Bug 36088 - Remove useless code form opac-account-pay.pl

The script opac-account-pay.pl sums the selected accountlines, formats the amount, pulls the currently active currency, and does nothing with any of this data.

Test Plan:
1) Apply this patch
2) Restart all the things!
3) Note there is no change in behavior
Comment 2 David Nind 2024-02-16 22:46:16 UTC
Created attachment 162251 [details] [review]
Bug 36088 - Remove useless code form opac-account-pay.pl

The script opac-account-pay.pl sums the selected accountlines, formats the amount, pulls the currently active currency, and does nothing with any of this data.

Test Plan:
1) Apply this patch
2) Restart all the things!
3) Note there is no change in behavior

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2024-02-16 23:01:34 UTC
Testing notes (using KTD):

1. I'm not sure that I've tested this correctly. Do I need to add a payment plugin, such as the paypal one, to test this change? If I haven't tested correctly, please change status back to needs signoff.

2. I added some charges for a patron, and then added a payment and a write off.

3. In the OPAC I made sure that the figures shown in the charges tab add up correctly.
Comment 4 Pedro Amorim 2024-02-20 09:55:04 UTC
Created attachment 162288 [details] [review]
Bug 36088 - Remove useless code form opac-account-pay.pl

The script opac-account-pay.pl sums the selected accountlines, formats the amount, pulls the currently active currency, and does nothing with any of this data.

Test Plan:
1) Apply this patch
2) Restart all the things!
3) Note there is no change in behavior

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Comment 5 Pedro Amorim 2024-02-20 10:08:03 UTC
Created attachment 162289 [details] [review]
Bug 36088: Remove useless code form opac-account-pay.pl

The script opac-account-pay.pl sums the selected accountlines, formats the amount, pulls the currently active currency, and does nothing with any of this data.

Test Plan:
1) Apply this patch
2) Restart all the things!
3) Note there is no change in behavior

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>

PA amended title (missing 'Bug ####:'
Comment 6 Katrin Fischer 2024-03-07 14:04:26 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 7 Fridolin Somers 2024-03-11 09:30:18 UTC
Pushed to 23.11.x for 23.11.04
Comment 8 Lucas Gass 2024-03-19 15:14:36 UTC
Backported to 23.05.x for upcoming 23.05.10