Bug 36138 - Add cancellation reason to opac-holdshistory.pl's Status column
Summary: Add cancellation reason to opac-holdshistory.pl's Status column
Status: Passed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Lucas Gass
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-02-20 20:48 UTC by Lucas Gass
Modified: 2024-02-26 09:40 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 36138: Add reason to status column on opac-holdshistory, if there is a reason (2.17 KB, patch)
2024-02-20 20:52 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 36138: Add reason to status column on opac-holdshistory, if there is a reason (2.22 KB, patch)
2024-02-23 20:39 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 36138: Add reason to status column on opac-holdshistory, if there is a reason (2.28 KB, patch)
2024-02-26 09:40 UTC, Pedro Amorim
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass 2024-02-20 20:48:05 UTC
On the staff interface the Status column on members/holdshistory.pl includes the reason for cancellation, if there is one. 

We should add this to Status column on opac-holdshistory.pl as well.
Comment 1 Lucas Gass 2024-02-20 20:52:54 UTC
Created attachment 162309 [details] [review]
Bug 36138: Add reason to status column on opac-holdshistory, if there is a reason

TO TEST:
1. Turn on OPACHoldsHistory
2. Make some holds for a patron and then cancel them with a reason.
3. Log in as that patron and go to the 'Holds history' tab. Notice the text in the 'Status' column is 'Cancelled' but nothing shows up regarding the reason.
4. Apply patch and try again, this time you should see the reason for cancellation.
Comment 2 Biblibre Sandboxes 2024-02-23 20:39:31 UTC
Created attachment 162404 [details] [review]
Bug 36138: Add reason to status column on opac-holdshistory, if there is a reason

TO TEST:
1. Turn on OPACHoldsHistory
2. Make some holds for a patron and then cancel them with a reason.
3. Log in as that patron and go to the 'Holds history' tab. Notice the text in the 'Status' column is 'Cancelled' but nothing shows up regarding the reason.
4. Apply patch and try again, this time you should see the reason for cancellation.

Signed-off-by: Esther <esther@bywatersolutions.com>
Comment 3 Pedro Amorim 2024-02-26 09:40:08 UTC
Created attachment 162425 [details] [review]
Bug 36138: Add reason to status column on opac-holdshistory, if there is a reason

TO TEST:
1. Turn on OPACHoldsHistory
2. Make some holds for a patron and then cancel them with a reason.
3. Log in as that patron and go to the 'Holds history' tab. Notice the text in the 'Status' column is 'Cancelled' but nothing shows up regarding the reason.
4. Apply patch and try again, this time you should see the reason for cancellation.

Signed-off-by: Esther <esther@bywatersolutions.com>
Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>