36619 – Cannot show/hide columns on the patron search table when placing a hold

Bug 36619 - Cannot show/hide columns on the patron search table when placing a hold

Summary: Cannot show/hide columns on the patron search table when placing a hold

Status:	Pushed to oldstable

Alias:	None

Product:	Koha
Classification:	Unclassified
Component:	Circulation (show other bugs)
Version:	unspecified
Hardware:	All All

Importance:	P5 - low minor
Assignee:	Jonathan Druart
QA Contact:	Martin Renvoize (ashimema)

URL:
Keywords:

Depends on:	30093
Blocks:
	Show dependency tree / graph

Reported:	2024-04-17 10:17 UTC by Jonathan Druart
Modified:	2024-07-25 11:11 UTC (History)
CC List:	5 users (show)

See Also:
Change sponsored?:	---
Patch complexity:	Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:	24.05.00,23.11.06,23.05.12
Circulation function:

Attachments
Bug 36619: Restore 'Columns' visibility on the patron search when placing a hold (1.29 KB, patch) 2024-04-17 10:19 UTC, Jonathan Druart	Details \| Diff \| Splinter Review
Bug 36619: Restore 'Columns' visibility on the patron search when placing a hold (1.36 KB, patch) 2024-04-17 14:53 UTC, Caroline Cyr La Rose	Details \| Diff \| Splinter Review
Bug 36619: Restore 'Columns' visibility on the patron search when placing a hold (1.43 KB, patch) 2024-05-15 06:57 UTC, Martin Renvoize (ashimema)	Details \| Diff \| Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jonathan Druart 2024-04-17 10:17:46 UTC

Comment 1 Jonathan Druart 2024-04-17 10:19:13 UTC

Created attachment 164990 [details] [review]
Bug 36619: Restore 'Columns' visibility on the patron search when placing a hold

Test plan:
Go to /cgi-bin/koha/reserve/request.pl?biblionumber=117
Search for "d"
Notice that with this patch applied the "Columns" button is back and
that the "Configure" is working correctly

Comment 2 Caroline Cyr La Rose 2024-04-17 14:53:48 UTC

Created attachment 165022 [details] [review]
Bug 36619: Restore 'Columns' visibility on the patron search when placing a hold

Test plan:
Go to /cgi-bin/koha/reserve/request.pl?biblionumber=117
Search for "d"
Notice that with this patch applied the "Columns" button is back and
that the "Configure" is working correctly

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>

Comment 3 Caroline Cyr La Rose 2024-04-17 14:54:28 UTC

Thanks Jonathan! I had noticed the button was missing this morning and I thought it was just me :)

Comment 4 Martin Renvoize (ashimema) 2024-05-15 06:57:52 UTC

Created attachment 166750 [details] [review]
Bug 36619: Restore 'Columns' visibility on the patron search when placing a hold

Test plan:
Go to /cgi-bin/koha/reserve/request.pl?biblionumber=117
Search for "d"
Notice that with this patch applied the "Columns" button is back and
that the "Configure" is working correctly

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Comment 5 Katrin Fischer 2024-05-17 08:37:38 UTC

Pushed for 24.05!

Well done everyone, thank you!

Comment 6 Fridolin Somers 2024-05-29 13:10:39 UTC

Pushed to 23.11.x for 23.11.06

Comment 7 Lucas Gass (lukeg) 2024-05-30 19:46:23 UTC

Backported to 23.05.x for upcoming 23.05.12