I'm unable to delete a budget that has no funds, even with superlibrarian privileges. To recreate: 1. Go to Administration > Budgets 2. Click New budget 3. Enter a start and end date, a name and an amount (For the test, I entered April 1st, 2024 to April 30, 2024, named the budget "April", and gave it an amount of 100) 4. Click Save 5. Go to Inactive budgets 6. Click Actions next to the budget and choose the Delete option 7. Click Yes, delete 8. Go to Inactive budgets --> The budget is still there
I noticed the budget name is not in the warning message in step 7, but the budget_period_id is in the URL, so I'm not sure what is happening.
Created attachment 165957 [details] [review] Bug 36739: Correct CSRF change to budget deletions This is another instance of the deletion confirmation step getting mistakenly auto-updated as if it were the deletion step. The 'delete_confirm' doesn't need the 'cud-' prefix, only the 'delete_confirmed' step. To test, apply the patch and restart services. - Test the process of deleting a budget. - On the confirmation step you should see the name of the budget you're about to delete. - After confirming, the deletion should complete correctly.
Created attachment 165966 [details] [review] Bug 36739: Correct CSRF change to budget deletions This is another instance of the deletion confirmation step getting mistakenly auto-updated as if it were the deletion step. The 'delete_confirm' doesn't need the 'cud-' prefix, only the 'delete_confirmed' step. To test, apply the patch and restart services. - Test the process of deleting a budget. - On the confirmation step you should see the name of the budget you're about to delete. - After confirming, the deletion should complete correctly. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Thanks Owen!
Created attachment 166879 [details] [review] Bug 36739: Correct CSRF change to budget deletions This is another instance of the deletion confirmation step getting mistakenly auto-updated as if it were the deletion step. The 'delete_confirm' doesn't need the 'cud-' prefix, only the 'delete_confirmed' step. To test, apply the patch and restart services. - Test the process of deleting a budget. - On the confirmation step you should see the name of the budget you're about to delete. - After confirming, the deletion should complete correctly. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed for 24.05! Well done everyone, thank you!
Not for 23.11.x
Bug fix, nothing to add/edit in the Koha manual.