Bug 36787 - staticfines.pl missing use Koha::DateUtils::output_pref
Summary: staticfines.pl missing use Koha::DateUtils::output_pref
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Command-line Utilities (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Fridolin Somers
QA Contact: Testopia
URL:
Keywords:
Depends on: 17600
Blocks:
  Show dependency tree / graph
 
Reported: 2024-05-06 10:06 UTC by Fridolin Somers
Modified: 2024-05-28 21:48 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.06,23.05.12
Circulation function:

Attachments
Bug 36787: staticfines.pl add use Koha::DateUtils::output_pref (1013 bytes, patch)
2024-05-06 10:11 UTC, Fridolin Somers 		Details | Diff | Splinter Review
Bug 36787: staticfines.pl add use Koha::DateUtils::output_pref (1.07 KB, patch)
2024-05-07 13:52 UTC, Matt Blenkinsop 		Details | Diff | Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2024-05-06 10:06:25 UTC 
misc/cronjobs/staticfines.pl is calling output_pref() but it is missing from module import :
use Koha::DateUtils qw( dt_from_string );
Comment 1 Fridolin Somers 2024-05-06 10:11:33 UTC 
Created attachment 166195 [details] [review]
Bug 36787: staticfines.pl add use Koha::DateUtils::output_pref

misc/cronjobs/staticfines.pl is calling output_pref() but it is missing from module import :
use Koha::DateUtils qw( dt_from_string );

Test but running staticfines.pl
Comment 2 Matt Blenkinsop 2024-05-07 13:52:24 UTC 
Created attachment 166287 [details] [review]
Bug 36787: staticfines.pl add use Koha::DateUtils::output_pref

misc/cronjobs/staticfines.pl is calling output_pref() but it is missing from module import :
use Koha::DateUtils qw( dt_from_string );

Test but running staticfines.pl

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Comment 3 Katrin Fischer 2024-05-07 15:03:54 UTC 
Picking this out of QA queue.
Comment 4 Emily Lamancusa (emlam) 2024-05-09 14:34:44 UTC 
Katrin, did you end up pushing this? It's still set to SO.
Comment 5 Katrin Fischer 2024-05-09 15:22:25 UTC 
Yes I did, but forgot to change the status, then the script doesn't pick it up.
https://git.koha-community.org/Koha-community/Koha/commits/branch/main/search?q=36787
Comment 6 Fridolin Somers 2024-05-24 14:48:28 UTC 
Pushed to 23.11.x for 23.11.06
Comment 7 Lucas Gass (lukeg) 2024-05-28 21:48:14 UTC 
Backported to 23.05.x for upcoming 23.05.12