Bug 36905 - Terminology: home locations / home collections
Summary: Terminology: home locations / home collections
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low trivial
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-21 09:57 UTC by Katrin Fischer
Modified: 2024-11-18 16:51 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This removes the unnecessary word "home" from several aria-labels in OPAC search facets. For example, "Show more home locations" was changed to "Show more locations". (Note that there is no visible change to the OPAC.)
Version(s) released in:
24.11.00,24.05.06
Circulation function:

Attachments
Bug 36905: Terminology: home locations / home collections (3.09 KB, patch)
2024-06-13 12:04 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 36905: Terminology: home locations / home collections (3.13 KB, patch)
2024-06-13 21:31 UTC, David Nind 		Details | Diff | Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2024-05-21 09:57:49 UTC 
Show more home collections
Show more home locations
Show more home languages

I think they should not have the home included?

Same for the "Show fewer"

koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc:124
Comment 1 Owen Leonard 2024-06-13 12:04:10 UTC 
Created attachment 167685 [details] [review]
Bug 36905: Terminology: home locations / home collections

This patch removes the unnecessary word "home" from several aria-lablels
in OPAC facets. I think they were copy-paste errors.

To test, apply the patch and perform a catalog search in the OPAC.

Since the aria-label isn't visible in the interface, you can check the
source to confirm that the "Show more" links for locations, collections,
and languages say "Show more locations," "Show more collections," and
"Show more languages."
Comment 2 David Nind 2024-06-13 21:31:20 UTC 
Created attachment 167698 [details] [review]
Bug 36905: Terminology: home locations / home collections

This patch removes the unnecessary word "home" from several aria-lablels
in OPAC facets. I think they were copy-paste errors.

To test, apply the patch and perform a catalog search in the OPAC.

Since the aria-label isn't visible in the interface, you can check the
source to confirm that the "Show more" links for locations, collections,
and languages say "Show more locations," "Show more collections," and
"Show more languages."

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2024-06-13 21:33:28 UTC 
Testing notes using KTD:

1. I wasn't able to test using the OPAC, as there doesn't seem to be enough sample data to make the facets show as per the test plan. I just reviewed the diff.
Comment 4 Katrin Fischer 2024-06-27 13:23:24 UTC 
Picked from QA queue for main.
Comment 5 Katrin Fischer 2024-06-27 15:26:42 UTC 
Pushed for 24.11!

Well done everyone, thank you!
Comment 6 Lucas Gass (lukeg) 2024-11-18 16:51:42 UTC 
Backported to 24.05.x for upcoming 24.05.06