Bug 36938 - Biblio.t generates warnings
Summary: Biblio.t generates warnings
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal
Assignee: Nick Clemens (kidclamp)
QA Contact: Matt Blenkinsop
URL:
Keywords:
Depends on: 31185
Blocks: 25515
  Show dependency treegraph
 
Reported: 2024-05-23 07:48 UTC by Jonathan Druart
Modified: 2024-07-25 23:11 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the cause of warnings generated by the bibliographic tests.
Version(s) released in:
24.11.00,24.05.02,23.11.07
Circulation function:


Attachments
Bug 36938: Adjusts tests to remove warns (1.28 KB, patch)
2024-05-30 15:20 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
Bug 36938: Adjusts tests to remove warns (1.36 KB, patch)
2024-06-03 13:33 UTC, Matt Blenkinsop
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2024-05-23 07:48:01 UTC
koha_1       | My biblionumber is 1656 and my frameworkcode is  at t/db_dependent/Biblio.t line 97.
koha_1       | My biblionumber is 1657 and my frameworkcode is  at t/db_dependent/Biblio.t line 97.

koha_1       | Use of uninitialized value $match_count in numeric gt (>) at /kohadevbox/koha/C4/Biblio.pm line 721.
koha_1       | Use of uninitialized value $match_count in numeric gt (>) at /kohadevbox/koha/C4/Biblio.pm line 721.
koha_1       | Use of uninitialized value $match_count in numeric gt (>) at /kohadevbox/koha/C4/Biblio.pm line 721.
koha_1       | Use of uninitialized value $match_count in numeric gt (>) at /kohadevbox/koha/C4/Biblio.pm line 721.
koha_1       | [15:19:03] t/db_dependent/Biblio.t 


The last ones are coming from bug 31185.
Comment 1 Nick Clemens (kidclamp) 2024-05-30 15:20:32 UTC
Created attachment 167275 [details] [review]
Bug 36938: Adjusts tests to remove warns
Comment 2 Nick Clemens (kidclamp) 2024-05-30 15:20:50 UTC
Trivial, sending to QA
Comment 3 Matt Blenkinsop 2024-06-03 13:33:50 UTC
Created attachment 167344 [details] [review]
Bug 36938: Adjusts tests to remove warns

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Comment 4 Martin Renvoize 2024-06-10 15:27:28 UTC
Thanks for all the hard work!

Pushed to main for the next 24.11.00 release as RM Assistant
Comment 5 Lucas Gass 2024-06-27 21:59:31 UTC
Backported to 24.05.x for upcoming 24.05.02
Comment 6 Fridolin Somers 2024-07-17 13:36:31 UTC
Pushed to 23.11.x for 23.11.07
Comment 7 wainuiwitikapark 2024-07-19 03:21:57 UTC
not backporting to 23.05.x unless requested