Bug 37059 - 'Insert' button is not working in notices and slips tool
Summary: 'Insert' button is not working in notices and slips tool
Status: Needs documenting
Alias: None
Product: Koha
Classification: Unclassified
Component: Notices (show other bugs)
Version: Main
Hardware: All Linux
: P5 - low major
Assignee: Brendan Lawlor
QA Contact: Lucas Gass (lukeg)
URL:
Keywords: rel_23_11_candidate
Depends on: 35882
Blocks:
  Show dependency tree / graph
 
Reported: 2024-06-10 10:52 UTC by Dr. Dilipkumar Vala
Modified: 2024-09-02 12:45 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the button used to insert fields into the body of a notice - it was not working (Tools > Notices and slips > Edit any notice > expand a notice type > select a field on the left-hand side > Insert).
Version(s) released in:
24.11.00,24.05.02
Circulation function:

Attachments
Bug 37059: Fix insert button in notices and slips (1.25 KB, patch)
2024-06-24 14:58 UTC, Brendan Lawlor 		Details | Diff | Splinter Review
Bug 37059: Fix insert button in notices and slips (1.30 KB, patch)
2024-06-24 16:17 UTC, Eric Garcia 		Details | Diff | Splinter Review
Bug 37059: Fix insert button in notices and slips (1.36 KB, patch)
2024-06-24 16:18 UTC, Lucas Gass (lukeg) 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dr. Dilipkumar Vala 2024-06-10 10:52:32 UTC 
In Tool menu, Notices and slips, edit any notice unable to insert the command in the message body. The insert button is not working.
Comment 1 Brendan Lawlor 2024-06-24 14:58:29 UTC 
Created attachment 168016 [details] [review]
Bug 37059: Fix insert button in notices and slips

This patch fixes the insert button in notices and slips. The container id needed to be appened with '_panel'

To Test:
1. Edit any notice or slip and try to use the insert button
2. Nothing happens
3. Apply patch and refresh the browser
4. Edit any notice or slip and use the insert button
5. Confirm the parameters are inserted into the tempalte as expected.
Comment 2 Katrin Fischer 2024-06-24 14:59:05 UTC 
Thx Brendan!
Comment 3 Eric Garcia 2024-06-24 16:17:03 UTC 
Created attachment 168027 [details] [review]
Bug 37059: Fix insert button in notices and slips

This patch fixes the insert button in notices and slips. The container id needed to be appened with '_panel'

To Test:
1. Edit any notice or slip and try to use the insert button
2. Nothing happens
3. Apply patch and refresh the browser
4. Edit any notice or slip and use the insert button
5. Confirm the parameters are inserted into the tempalte as expected.

Signed-off-by: Eric Garcia <cubingguy714@gmail.com>
Comment 4 Lucas Gass (lukeg) 2024-06-24 16:18:17 UTC 
Trivial change, makes sense, scripts are happy. Passing QA
Comment 5 Lucas Gass (lukeg) 2024-06-24 16:18:57 UTC 
Created attachment 168028 [details] [review]
Bug 37059: Fix insert button in notices and slips

This patch fixes the insert button in notices and slips. The container id needed to be appened with '_panel'

To Test:
1. Edit any notice or slip and try to use the insert button
2. Nothing happens
3. Apply patch and refresh the browser
4. Edit any notice or slip and use the insert button
5. Confirm the parameters are inserted into the tempalte as expected.

Signed-off-by: Eric Garcia <cubingguy714@gmail.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 6 Katrin Fischer 2024-06-25 16:37:05 UTC 
Pushed for 24.11!

Well done everyone, thank you!
Comment 7 Dr. Dilipkumar Vala 2024-06-26 09:48:21 UTC 
Thank you..!!
Comment 8 Catrina Berka 2024-07-17 20:53:32 UTC 
Can we get this backported to 24.05?
Comment 9 Lucas Gass (lukeg) 2024-07-17 20:58:37 UTC 
Backported to 24.05.x for upcoming 24.05.02
Comment 10 Fridolin Somers 2024-07-19 07:28:16 UTC 
Pushed to 23.11.x for 23.11.07
Comment 11 David Cook 2024-08-26 00:10:03 UTC 
(In reply to Fridolin Somers from comment #10)
> Pushed to 23.11.x for 23.11.07

It looks like this shouldn't have been backported to 23.11.07, as now the insert button is broken in that version.

I think bug 37059 should've had a dependency on bug 35882. 

So 23.11.09 should revert this change...
Comment 12 Katrin Fischer 2024-08-26 07:51:25 UTC 
(In reply to David Cook from comment #11)
> (In reply to Fridolin Somers from comment #10)
> > Pushed to 23.11.x for 23.11.07
> 
> It looks like this shouldn't have been backported to 23.11.07, as now the
> insert button is broken in that version.
> 
> I think bug 37059 should've had a dependency on bug 35882. 
> 
> So 23.11.09 should revert this change...

*ping Frido*
Comment 13 Fridolin Somers 2024-09-02 12:45:25 UTC 
(In reply to David Cook from comment #11)
> (In reply to Fridolin Somers from comment #10)
> > Pushed to 23.11.x for 23.11.07
> 
> It looks like this shouldn't have been backported to 23.11.07, as now the
> insert button is broken in that version.
> 
> I think bug 37059 should've had a dependency on bug 35882. 
> 
> So 23.11.09 should revert this change...

Oups indeed.
Reverted