Bug 37172 - HoldItem and HoldTitle do not check all the values of "hold_fulfillment_policy" rule
Summary: HoldItem and HoldTitle do not check all the values of "hold_fulfillment_polic...
Status: ASSIGNED
Alias: None
Product: Koha
Classification: Unclassified
Component: Web services (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement
Assignee: Arthur Suzuki
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-06-24 13:51 UTC by Arthur Suzuki
Modified: 2024-09-12 12:54 UTC (History)
1 user (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 37172 - HoldItem and HoldTitle do not check all the values of "hold_fulfillment_policy" rule (3.24 KB, patch)
2024-06-24 13:56 UTC, Arthur Suzuki 		Details | Diff | Splinter Review
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Arthur Suzuki 2024-06-24 13:51:44 UTC 
values "homebranch" and "holdingbranch" are not checked, leading to forbidden holds to be put from the ILS-DI interface.

I think the controls on "hold_fulfillment_policy" should be done in "CanItemBeReserved" rather than "CheckReserves".
Comment 1 Arthur Suzuki 2024-06-24 13:56:12 UTC 
Created attachment 168013 [details] [review]
Bug 37172 - HoldItem and HoldTitle do not check all the values of "hold_fulfillment_policy" rule
Comment 2 Fridolin Somers 2024-07-03 09:45:18 UTC 
Yop

You must fix commit message ( : not - )

See
https://wiki.koha-community.org/wiki/Commit_messages#Subject_line
Comment 3 Fridolin Somers 2024-09-12 12:54:55 UTC 
+    # Pickup branch management}
Typo ?