Bug 37250 - Redesign labels home page to match other module home pages
Summary: Redesign labels home page to match other module home pages
Status: Patch doesn't apply
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 37222
Blocks: 37581
  Show dependency treegraph
 
Reported: 2024-07-03 18:24 UTC by Owen Leonard
Modified: 2025-01-31 14:54 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This enhancement changes the label creator home page (Cataloging > Tools > Label creator) so that it shows the links which previously were buried in a dropdown menu.
Version(s) released in:
Circulation function:


Attachments
Bug 37250: Redesign labels home page to match other module home pages (7.30 KB, patch)
2024-07-03 18:33 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 37250: Redesign labels home page to match other module home pages (9.06 KB, patch)
2024-07-05 18:10 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 37250: Redesign labels home page to match other module home pages (9.09 KB, patch)
2024-07-05 23:24 UTC, David Nind
Details | Diff | Splinter Review
Bug 37250: (follow-up) More improvements to menus (12.04 KB, patch)
2024-07-22 14:31 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 37250: Redesign labels home page to match other module home pages (9.21 KB, patch)
2024-09-05 12:41 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 37250: (follow-up) More improvements to menus (12.17 KB, patch)
2024-09-05 12:41 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2024-07-03 18:24:47 UTC
I propose to update the label creator home page so that it has a grid of links like the circulation or cataloging home pages.
Comment 1 Owen Leonard 2024-07-03 18:33:26 UTC Comment hidden (obsolete)
Comment 2 Caroline Cyr La Rose 2024-07-03 18:52:55 UTC
I did reset_all after applying the patch and I'm still getting an error when I click on any of the buttons

Template process failed: file error - labels-menu.inc: not found at /kohadevbox/koha/C4/Templates.pm line 134
Comment 3 David Nind 2024-07-03 20:39:31 UTC
(In reply to Caroline Cyr La Rose from comment #2)
> I did reset_all after applying the patch and I'm still getting an error when
> I click on any of the buttons
> 
> Template process failed: file error - labels-menu.inc: not found at
> /kohadevbox/koha/C4/Templates.pm line 134

I get the same. No CSS changes, so no yarn build required. A restart_all was all that I did after applying the patch.
Comment 4 Owen Leonard 2024-07-05 18:10:47 UTC Comment hidden (obsolete)
Comment 5 Owen Leonard 2024-07-05 18:13:43 UTC
(In reply to David Nind from comment #3)
> > Template process failed: file error - labels-menu.inc: not found at
> > /kohadevbox/koha/C4/Templates.pm line 134

Sorry, I forgot to commit the new file!
Comment 6 David Nind 2024-07-05 23:24:34 UTC
Created attachment 168569 [details] [review]
Bug 37250: Redesign labels home page to match other module home pages

This patch changes the labels home page so that it shows the links which
previously were buried in a dropdown menu. Generally speaking we
shouldn't be using the button toolbar for navigation.

To test, apply the patch and go to Cataloging -> Label creator.

- You should see links styled like they are on the circulation or
  cataloging home page.
- If you follow any of those links you should see a new menu in the
  sidebar which has all the navigation items previously in the "Manage"
  dropdown menu.

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>
Comment 7 David Nind 2024-07-05 23:30:17 UTC
(In reply to Owen Leonard from comment #5)
> (In reply to David Nind from comment #3)
> > > Template process failed: file error - labels-menu.inc: not found at
> > > /kohadevbox/koha/C4/Templates.pm line 134
> 
> Sorry, I forgot to commit the new file!

Thanks Owen!

I like the updated layout.

I have some suggestions, but I think these would probably be better as new bugs:

1. When you are in any of the areas, there is a new sidebar at the top with Label batches, Label layouts, etc:
   - These are highlighted when you are in that section, but not when you are
     on the new form for each of them (don't know if it is possible to highlight 
     these in this case)
   - There is no "Print barcode range" in this new sidebar (see the additional 
     suggestion below)
   - Should this display when you are just on the label creator page?

2. Dropdown list for +New: change "Layout" to "Label layout" (matches with page 
   heading, and new top sidebar label, and is more consistent with other new
   items).

3. Print barcode range: as this is not saved, or editable later on, maybe this:
   - could have it's own button on the label creator home page
   - could have it's own action button next to +New
   - I don't think it quite fits under +New

4. Breadcrumbs (and page titles):
   - New label batches:  Label creator > Label batches> New label batch 
     (currently just Batches)
   - New label layouts:  Label creator > Label layouts > New label layouts 
     (currently just Layouts)
   - New label template:  Label creator > Label templates > New label template 
     (currently just Templates)
   - New printer profile: Label creator > Printer profiles > New printer  
     profiles (currently just Profiles)
Comment 8 David Nind 2024-07-05 23:33:04 UTC
Testing notes (using KTD):

1. Update the CSS (required for dependent bug): yarn build
Comment 9 Owen Leonard 2024-07-22 14:31:41 UTC
Created attachment 169307 [details] [review]
Bug 37250: (follow-up) More improvements to menus

- Add highlighting to new sidebar menu
- Make labels more consistent in menus, breadcrumbs, and titles
- Add 'Print barcode range' link to the labels home page and sidebar
  menu.
Comment 10 Owen Leonard 2024-09-05 12:41:33 UTC
Created attachment 171067 [details] [review]
Bug 37250: Redesign labels home page to match other module home pages

This patch changes the labels home page so that it shows the links which
previously were buried in a dropdown menu. Generally speaking we
shouldn't be using the button toolbar for navigation.

To test, apply the patch and go to Cataloging -> Label creator.

- You should see links styled like they are on the circulation or
  cataloging home page.
- If you follow any of those links you should see a new menu in the
  sidebar which has all the navigation items previously in the "Manage"
  dropdown menu.

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>
Comment 11 Owen Leonard 2024-09-05 12:41:35 UTC
Created attachment 171068 [details] [review]
Bug 37250: (follow-up) More improvements to menus

- Add highlighting to new sidebar menu
- Make labels more consistent in menus, breadcrumbs, and titles
- Add 'Print barcode range' link to the labels home page and sidebar
  menu.
Comment 12 Lucas Gass (lukeg) 2025-01-31 14:54:09 UTC
Doesn't seem to apply cleanly now. Maybe due due to Bug 37250.