37290 – Deleting circulation rule for a specific library deletes for All libraries instead

Bug 37290 - Deleting circulation rule for a specific library deletes for All libraries instead

Summary: Deleting circulation rule for a specific library deletes for All libraries in...

Status:	Needs documenting

Alias:	None

Product:	Koha
Classification:	Unclassified
Component:	Circulation (show other bugs)
Version:	Main
Hardware:	All All

Importance:	P5 - low major
Assignee:	Janusz Kaczmarek
QA Contact:	Pedro Amorim

URL:
Keywords:

Depends on:	34478
Blocks:	37263
	Show dependency tree / graph

Reported:	2024-07-09 13:39 UTC by Pedro Amorim
Modified:	2024-10-21 13:30 UTC (History)
CC List:	10 users (show)

See Also:
Change sponsored?:	---
Patch complexity:	Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:	24.11.00,24.05.05
Circulation function:

Attachments
Bug 37290: Fix data-branch param (7.47 KB, patch) 2024-07-09 13:42 UTC, Pedro Amorim	Details \| Diff \| Splinter Review
Bug 37290: Fix data-branch param (7.54 KB, patch) 2024-07-10 05:44 UTC, Emmi Takkinen	Details \| Diff \| Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Pedro Amorim 2024-07-09 13:39:26 UTC

Comment 1 Pedro Amorim 2024-07-09 13:42:13 UTC

Created attachment 168649 [details] [review]
Bug 37290: Fix data-branch param

1) Add circulation rules for a specific library
2) Attempt to remove one of those library specific rules -> get redirected to 'All'
3) Notice the rule for that specific branch is still there

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>

Comment 2 Pedro Amorim 2024-07-09 13:46:47 UTC

Bug first reported and fix submitted by Janusz:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37263#c10

Comment 3 Emmi Takkinen 2024-07-10 05:44:26 UTC

Created attachment 168689 [details] [review]
Bug 37290: Fix data-branch param

1) Add circulation rules for a specific library
2) Attempt to remove one of those library specific rules -> get redirected to 'All'
3) Notice the rule for that specific branch is still there

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi>

Comment 4 Martin Renvoize (ashimema) 2024-07-15 17:34:50 UTC

With Pedro and Emmi on the SO here and a quick look from me I'm upgrading this to PQA

Comment 5 Katrin Fischer 2024-07-18 13:58:03 UTC

Small changes to fix a big bug, thanks!

Comment 6 Katrin Fischer 2024-07-18 15:57:17 UTC

Pushed for 24.11!

Well done everyone, thank you!

Comment 7 Alex Carver 2024-09-18 11:49:54 UTC

Commenting in support of backporting this fix to 24.05.

Comment 8 Chanel Wheeler 2024-09-25 21:02:35 UTC

Yes, please backport to 24.05. We have 58 libraries that this could affect.

Comment 9 Lucas Gass (lukeg) 2024-10-09 21:56:23 UTC

Backported to 24.05.05 for upcoming 24.05.05

Comment 10 Fridolin Somers 2024-10-21 13:30:39 UTC

Depends on Bug 34478 not in 23.11.x