Bug 37401 - Wrong i index of inputs for 'Unlimited' values
Summary: Wrong i index of inputs for 'Unlimited' values
Status: CLOSED WORKSFORME
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement
Assignee: Peter Vashchuk
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-07-18 12:32 UTC by Peter Vashchuk
Modified: 2025-06-02 20:45 UTC (History)
2 users (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 37401: Fix incorrect index in smart-rules.tt (2.06 KB, patch)
2024-07-18 12:43 UTC, Peter Vashchuk
Details | Diff | Splinter Review
Bug 37401: Fix incorrect index in smart-rules.tt (2.11 KB, patch)
2024-07-18 17:41 UTC, Roman Dolny
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Vashchuk 2024-07-18 12:32:28 UTC

    
Comment 1 Peter Vashchuk 2024-07-18 12:43:49 UTC
Created attachment 169131 [details] [review]
Bug 37401: Fix incorrect index in smart-rules.tt

This patch corrects the index for the "Current checkouts allowed" column.

To reproduce:
1. Go to Administration -> Circulation and Fine Rules.
2. Add or edit a rule so that "Current checkouts allowed" and "Current on-site checkouts allowed" are set to "Unlimited."
3. Press the edit button to edit that rule, and see that the text edit field for "Current on-site checkouts allowed" is empty, as it should be, while "Current checkouts allowed" has a prefilled text value "Unlimited".
4. Apply the patch.
5. Repeat the third step and ensure that this time when you edit that rule, both text edit fields for "Current checkouts allowed" and "Current on-site checkouts allowed" are correctly empty.
Comment 2 Roman Dolny 2024-07-18 17:41:39 UTC
Created attachment 169160 [details] [review]
Bug 37401: Fix incorrect index in smart-rules.tt

This patch corrects the index for the "Current checkouts allowed" column.

To reproduce:
1. Go to Administration -> Circulation and Fine Rules.
2. Add or edit a rule so that "Current checkouts allowed" and "Current on-site checkouts allowed" are set to "Unlimited."
3. Press the edit button to edit that rule, and see that the text edit field for "Current on-site checkouts allowed" is empty, as it should be, while "Current checkouts allowed" has a prefilled text value "Unlimited".
4. Apply the patch.
5. Repeat the third step and ensure that this time when you edit that rule, both text edit fields for "Current checkouts allowed" and "Current on-site checkouts allowed" are correctly empty.

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Comment 3 Kyle M Hall (khall) 2024-10-18 16:59:22 UTC
This appears to be fixed in master. If you think I'm mistaken please reopen!