Created attachment 169131 [details] [review] Bug 37401: Fix incorrect index in smart-rules.tt This patch corrects the index for the "Current checkouts allowed" column. To reproduce: 1. Go to Administration -> Circulation and Fine Rules. 2. Add or edit a rule so that "Current checkouts allowed" and "Current on-site checkouts allowed" are set to "Unlimited." 3. Press the edit button to edit that rule, and see that the text edit field for "Current on-site checkouts allowed" is empty, as it should be, while "Current checkouts allowed" has a prefilled text value "Unlimited". 4. Apply the patch. 5. Repeat the third step and ensure that this time when you edit that rule, both text edit fields for "Current checkouts allowed" and "Current on-site checkouts allowed" are correctly empty.
Created attachment 169160 [details] [review] Bug 37401: Fix incorrect index in smart-rules.tt This patch corrects the index for the "Current checkouts allowed" column. To reproduce: 1. Go to Administration -> Circulation and Fine Rules. 2. Add or edit a rule so that "Current checkouts allowed" and "Current on-site checkouts allowed" are set to "Unlimited." 3. Press the edit button to edit that rule, and see that the text edit field for "Current on-site checkouts allowed" is empty, as it should be, while "Current checkouts allowed" has a prefilled text value "Unlimited". 4. Apply the patch. 5. Repeat the third step and ensure that this time when you edit that rule, both text edit fields for "Current checkouts allowed" and "Current on-site checkouts allowed" are correctly empty. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
This appears to be fixed in master. If you think I'm mistaken please reopen!