Bug 37452 - The 'Compare matched records' diff view page is missing page-sections
Summary: The 'Compare matched records' diff view page is missing page-sections
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Martin Renvoize (ashimema)
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-07-24 14:25 UTC by Martin Renvoize (ashimema)
Modified: 2024-11-15 17:53 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00
Circulation function:

Attachments
Bug 37452: Modernise the view in showdiffmarc (3.75 KB, patch)
2024-07-24 15:21 UTC, Martin Renvoize (ashimema) 		Details | Diff | Splinter Review
Bug 37452: Modernise the view in showdiffmarc (3.79 KB, patch)
2024-07-24 15:46 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 37452: Modernise the view in showdiffmarc (3.83 KB, patch)
2024-08-16 08:53 UTC, Marcel de Rooy 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize (ashimema) 2024-07-24 14:25:57 UTC 
We're missing the white background on the diff page for marc imports
Comment 1 Martin Renvoize (ashimema) 2024-07-24 15:21:56 UTC 
Created attachment 169499 [details] [review]
Bug 37452: Modernise the view in showdiffmarc

The showdiffmarc view available from manage stage records when a match
is found looks dated.

This patch adds a page-section, centers the display as a whole and
converts the link back to the staging area to an action button.
Comment 2 Owen Leonard 2024-07-24 15:46:23 UTC 
Created attachment 169500 [details] [review]
Bug 37452: Modernise the view in showdiffmarc

The showdiffmarc view available from manage stage records when a match
is found looks dated.

This patch adds a page-section, centers the display as a whole and
converts the link back to the staging area to an action button.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Marcel de Rooy 2024-08-16 08:53:31 UTC 
Created attachment 170441 [details] [review]
Bug 37452: Modernise the view in showdiffmarc

The showdiffmarc view available from manage stage records when a match
is found looks dated.

This patch adds a page-section, centers the display as a whole and
converts the link back to the staging area to an action button.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 4 Marcel de Rooy 2024-08-16 08:53:56 UTC 
Moving to enh, right?
Comment 5 Katrin Fischer 2024-08-27 10:15:15 UTC 
Pushed for 24.11!

Well done everyone, thank you!